This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Do not hardcode attribute indexes in intrinsic decls
ClosedPublic

Authored by tra on Mar 17 2023, 2:49 PM.

Details

Summary

We're not checking the attributes themselves, so hardcoded attribute numbers
only make the tests more fragile, without improving the testing.

Fixes MLIR test break caused by changes in intrinsic attributes introduced in 33260cf2c5

Diff Detail

Event Timeline

tra created this revision.Mar 17 2023, 2:49 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
tra published this revision for review.Mar 17 2023, 2:52 PM
tra edited the summary of this revision. (Show Details)
tra added a reviewer: arsenm.
arsenm accepted this revision.Mar 17 2023, 2:55 PM
This revision is now accepted and ready to land.Mar 17 2023, 2:55 PM
This revision was landed with ongoing or failed builds.Mar 17 2023, 3:03 PM
This revision was automatically updated to reflect the committed changes.