Page MenuHomePhabricator
Differential D146200

[PassBuilder] Support O0 in default pipelines
ClosedPublic
Actions

Authored by nikic on Thu, Mar 16, 2:02 AM.

Details

Reviewers
aeubanks
asbirlea
Commits
rGa8f6b5763e89: [PassBuilder] Support O0 in default pipelines
Summary

The default and pre-link pipeline builders currently require you to call a separate method for optimization level O0, even though they have perfectly well-defined O0 optimization pipelines.

Accept O0 optimization level and call buildO0DefaultPipeline() internally, so all consumers don't need to repeat this.

Diff Detail

Event Timeline

nikic created this revision.Thu, Mar 16, 2:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 2:02 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 24 others. · View Herald Transcript
nikic requested review of this revision.Thu, Mar 16, 2:02 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptThu, Mar 16, 2:02 AM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B219807: Diff 505726.Thu, Mar 16, 3:47 AM
aeubanks accepted this revision.Thu, Mar 16, 9:27 AM

yeah, the forced -O0 separation doesn't really make sense

This revision is now accepted and ready to land.Thu, Mar 16, 9:27 AM
asbirlea added inline comments.Thu, Mar 16, 10:58 AM
llvm/lib/Passes/PassBuilderPipelines.cpp
1554–1555

I'm missing why you're not calling buildO0DefaultPipeline for O0 here too.

nikic added inline comments.Thu, Mar 16, 11:02 AM
llvm/lib/Passes/PassBuilderPipelines.cpp
1554–1555

buildPerModuleDefaultPipeline() will call buildO0DefaultPipeline() in this case.

asbirlea accepted this revision.Thu, Mar 16, 1:58 PM
asbirlea added inline comments.
llvm/lib/Passes/PassBuilderPipelines.cpp
1554–1555

Ah, right! Thanks!

This revision was landed with ongoing or failed builds.Fri, Mar 17, 2:00 AM
Closed by commit rGa8f6b5763e89: [PassBuilder] Support O0 in default pipelines (authored by nikic). · Explain Why
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rGa8f6b5763e89: [PassBuilder] Support O0 in default pipelines.
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptFri, Mar 17, 2:00 AM
Herald added subscribers: openmp-commits, cfe-commits. · View Herald Transcript

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
4 lines
tools/
clang-fuzzer/
handle-llvm/
6 lines
flang/
lib/
Frontend/
5 lines
llvm/
include/
llvm/
Passes/
15 lines
lib/
Passes/
6 lines
10 lines
mlir/
lib/
ExecutionEngine/
6 lines
openmp/
libomptarget/
plugins-nextgen/
common/
PluginInterface/
6 lines

Diff 506007

View Options

clang/lib/CodeGen/BackendUtil.cpp

Loading...
View Options

clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

Loading...
View Options

flang/lib/Frontend/FrontendActions.cpp

Loading...
View Options

llvm/include/llvm/Passes/PassBuilder.h

Loading...
View Options

llvm/lib/Passes/PassBuilder.cpp

Loading...
View Options

llvm/lib/Passes/PassBuilderPipelines.cpp

Loading...
View Options

mlir/lib/ExecutionEngine/OptUtils.cpp

Loading...
View Options

openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp

Loading...