Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D146160

[StandardInstrumentations] Check function analysis invalidation in module passes as well
ClosedPublic
Actions

Authored by aeubanks on Mar 15 2023, 11:55 AM.

Details

Reviewers
yrouban
nikic
asbirlea
Commits
rG6a6994cc9bc0: Reland [StandardInstrumentations] Check function analysis invalidation in…
rGd6c0724eb158: [StandardInstrumentations] Check function analysis invalidation in module…
Summary

See comments for why we now need to pass in the MAM instead of the FAM.

Diff Detail

Event Timeline

aeubanks created this revision.Mar 15 2023, 11:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 11:55 AM
Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Mar 15 2023, 11:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 11:55 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B219702: Diff 505582.Mar 15 2023, 11:57 AM
nikic accepted this revision.Mar 15 2023, 12:53 PM

LGTM

This revision is now accepted and ready to land.Mar 15 2023, 12:53 PM
This revision was landed with ongoing or failed builds.Mar 15 2023, 1:23 PM
Closed by commit rGd6c0724eb158: [StandardInstrumentations] Check function analysis invalidation in module… (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGd6c0724eb158: [StandardInstrumentations] Check function analysis invalidation in module….
aeubanks added a reverting change: rG04d20195d6b3: Revert "[StandardInstrumentations] Check function analysis invalidation in….Mar 15 2023, 1:28 PM
aeubanks added a commit: rG6a6994cc9bc0: Reland [StandardInstrumentations] Check function analysis invalidation in….
aeubanks mentioned this in D146238: [StandardInstrumentations] Check that module analyses are properly invalidated.Mar 16 2023, 9:59 AM
aeubanks mentioned this in rG55140fbbcd65: [StandardInstrumentations] Check that module analyses are properly invalidated.Mar 17 2023, 9:11 AM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Passes/
4 lines
lib/
LTO/
2 lines
2 lines
Passes/
2 lines
119 lines
tools/
opt/
2 lines
unittests/
IR/
57 lines

Diff 505609

View Options

llvm/include/llvm/Passes/StandardInstrumentations.h

Loading...
View Options

llvm/lib/LTO/LTOBackend.cpp

Loading...
View Options

llvm/lib/LTO/ThinLTOCodeGenerator.cpp

Loading...
View Options

llvm/lib/Passes/PassBuilderBindings.cpp

Loading...
View Options

llvm/lib/Passes/StandardInstrumentations.cpp

Loading...
View Options

llvm/tools/opt/NewPMDriver.cpp

Loading...
View Options

llvm/unittests/IR/PassManagerTest.cpp

Loading...