Page MenuHomePhabricator

[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation
ClosedPublic

Authored by aeubanks on Tue, Mar 14, 10:26 AM.

Details

Summary

In preparation for adding more checks under this flag.

Diff Detail

Event Timeline

aeubanks created this revision.Tue, Mar 14, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 10:26 AM
aeubanks requested review of this revision.Tue, Mar 14, 10:26 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptTue, Mar 14, 10:26 AM
nikic added a comment.Wed, Mar 15, 9:30 AM

To me verify-preserved-analyses sounds like "if DominatorTree is preserved, calls DominatorTree::verify(), etc". That is, call verify on the preserved analyses.

Maybe verify-change-reporting or so?

aeubanks updated this revision to Diff 505539.Wed, Mar 15, 9:45 AM
aeubanks retitled this revision from [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses to [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation.

rename to verify-analysis-invalidation

This revision is now accepted and ready to land.Wed, Mar 15, 12:34 PM