This is an archive of the discontinued LLVM Phabricator instance.

[libc] Update supported riscv libs
ClosedPublic

Authored by mikhail.ramalho on Mar 14 2023, 10:07 AM.

Details

Summary

This patch removes some duplicated libs added to entrypoints.txt, adds
new libs supported to entrypoints.txt and updates header.txt

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 14 2023, 10:07 AM
mikhail.ramalho requested review of this revision.Mar 14 2023, 10:07 AM

I think you need to rebase this.

I think you need to rebase this.

This actually depends on the setjmp/longjmp patch... I added the dependency here on phabricator, but it seems like the bot doesn't get the parent revisions.

I'll manually restart the check once the setjmp/longjmp patch lands.

sivachandra added inline comments.Mar 14 2023, 11:15 AM
libc/config/linux/riscv64/entrypoints.txt
476

At the least, these functions are already enabled: https://github.com/llvm/llvm-project/blob/main/libc/config/linux/riscv64/entrypoints.txt#L456

That is the reason for my comment about rebasing.

Oh, I see. I'll rebase against main then.

Em ter., 14 de mar. de 2023 às 15:15, Siva Chandra via Phabricator <
reviews@reviews.llvm.org> escreveu:

sivachandra added inline comments.

Comment at: libc/config/linux/riscv64/entrypoints.txt:430
+ libc.src.unistd.optopt
+ libc.src.unistd.opterr

+

At the least, these functions are already enabled:
https://github.com/llvm/llvm-project/blob/main/libc/config/linux/riscv64/entrypoints.txt#L456

That is the reason for my comment about rebasing.

Repository:

rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

https://reviews.llvm.org/D146065/new/

https://reviews.llvm.org/D146065

sivachandra accepted this revision.Mar 14 2023, 12:19 PM
This revision is now accepted and ready to land.Mar 14 2023, 12:19 PM
This revision was landed with ongoing or failed builds.Mar 16 2023, 2:18 AM
This revision was automatically updated to reflect the committed changes.