This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Don't use -z,defs on sanitizer builds
ClosedPublic

Authored by rkayaith on Mar 13 2023, 9:50 AM.

Details

Summary

This works around link errors when building the python bindings with
ASAN, since the ASAN run-time doesn't get linked into shared libraries.
The ASAN docs specficially call out -z,defs as a potential issue:
https://clang.llvm.org/docs/AddressSanitizer.html#usage

closes https://github.com/llvm/llvm-project/issues/60565

Diff Detail

Event Timeline

rkayaith created this revision.Mar 13 2023, 9:50 AM
rkayaith published this revision for review.Mar 13 2023, 10:23 AM
mehdi_amini accepted this revision.Mar 13 2023, 10:24 AM
This revision is now accepted and ready to land.Mar 13 2023, 10:24 AM
stellaraccident accepted this revision.Mar 13 2023, 10:58 AM
This revision was landed with ongoing or failed builds.Mar 13 2023, 11:04 AM
This revision was automatically updated to reflect the committed changes.