This is an archive of the discontinued LLVM Phabricator instance.

Differential D145950

[lldb] Remove MipsLinuxSignals
AbandonedPublic

Authored by DavidSpickett on Mar 13 2023, 8:58 AM.

Details

Reviewers
labath
Summary

Support for Linux MIPS debugging was removed in
ce03a862372a6f36d2fcf80dc80052aa155fcae8.

Diff Detail

Event Timeline

DavidSpickett created this revision.Mar 13 2023, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 8:58 AM
Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. · View Herald Transcript
DavidSpickett requested review of this revision.Mar 13 2023, 8:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 13 2023, 8:58 AM
Herald added subscribers: llvm-commits, lldb-commits. · View Herald Transcript
DavidSpickett added a reviewer: labath.Mar 13 2023, 8:59 AM

One less set of signals I need to update to merge CrashReason into UnixSignals.

Herald added a subscriber: JDevlieghere. · View Herald TranscriptMar 13 2023, 8:59 AM
Harbormaster completed remote builds in B219065: Diff 504692.Mar 13 2023, 11:49 AM
DavidSpickett abandoned this revision.Mar 14 2023, 4:37 AM

Someone else had the same idea: https://github.com/llvm/llvm-project/commit/93a455375c0fa1dd014a3b4571b22e307d15bbf7

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
Utility/
1 line
Target/
14 lines
llvm/
utils/
gn/
secondary/
lldb/
source/
Plugins/
Process/
Utility/
1 line

Diff 504692

lldb/source/Plugins/Process/Utility/CMakeLists.txt

add_lldb_library(lldbPluginProcessUtility add_lldb_library(lldbPluginProcessUtility
AuxVector.cpp AuxVector.cpp
FreeBSDSignals.cpp FreeBSDSignals.cpp
GDBRemoteSignals.cpp GDBRemoteSignals.cpp
HistoryThread.cpp HistoryThread.cpp
HistoryUnwind.cpp HistoryUnwind.cpp
InferiorCallPOSIX.cpp InferiorCallPOSIX.cpp
LinuxProcMaps.cpp LinuxProcMaps.cpp
LinuxSignals.cpp LinuxSignals.cpp
MemoryTagManagerAArch64MTE.cpp MemoryTagManagerAArch64MTE.cpp
MipsLinuxSignals.cpp
NativeProcessSoftwareSingleStep.cpp NativeProcessSoftwareSingleStep.cpp
NativeRegisterContextDBReg_arm64.cpp NativeRegisterContextDBReg_arm64.cpp
NativeRegisterContextDBReg_x86.cpp NativeRegisterContextDBReg_x86.cpp
NativeRegisterContextRegisterInfo.cpp NativeRegisterContextRegisterInfo.cpp
NetBSDSignals.cpp NetBSDSignals.cpp
RegisterContext_x86.cpp RegisterContext_x86.cpp
RegisterContextDarwin_arm.cpp RegisterContextDarwin_arm.cpp
RegisterContextDarwin_arm64.cpp RegisterContextDarwin_arm64.cpp
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h

  • This file was deleted.
//===-- MipsLinuxSignals.h ------------------------------------------*- C++
//-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H
#define LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H
#include "lldb/Target/UnixSignals.h"
namespace lldb_private {
/// Linux specific set of Unix signals.
class MipsLinuxSignals : public UnixSignals {
public:
MipsLinuxSignals();
private:
void Reset() override;
};
} // namespace lldb_private
#endif // LLDB_SOURCE_PLUGINS_PROCESS_UTILITY_MIPSLINUXSIGNALS_H

lldb/source/Plugins/Process/Utility/MipsLinuxSignals.cpp

  • This file was deleted.
//===-- MipsLinuxSignals.cpp ----------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "MipsLinuxSignals.h"
using namespace lldb_private;
MipsLinuxSignals::MipsLinuxSignals() : UnixSignals() { Reset(); }
void MipsLinuxSignals::Reset() {
m_signals.clear();
// clang-format off
// SIGNO NAME SUPPRESS STOP NOTIFY DESCRIPTION
// ====== ============== ======== ====== ====== ===================================================
AddSignal(1, "SIGHUP", false, true, true, "hangup");
AddSignal(2, "SIGINT", true, true, true, "interrupt");
AddSignal(3, "SIGQUIT", false, true, true, "quit");
AddSignal(4, "SIGILL", false, true, true, "illegal instruction");
AddSignal(5, "SIGTRAP", true, true, true, "trace trap (not reset when caught)");
AddSignal(6, "SIGABRT", false, true, true, "abort()/IOT trap", "SIGIOT");
AddSignal(7, "SIGEMT", false, true, true, "terminate process with core dump");
AddSignal(8, "SIGFPE", false, true, true, "floating point exception");
AddSignal(9, "SIGKILL", false, true, true, "kill");
AddSignal(10, "SIGBUS", false, true, true, "bus error");
AddSignal(11, "SIGSEGV", false, true, true, "segmentation violation");
AddSignal(12, "SIGSYS", false, true, true, "invalid system call");
AddSignal(13, "SIGPIPE", false, true, true, "write to pipe with reading end closed");
AddSignal(14, "SIGALRM", false, false, false, "alarm");
AddSignal(15, "SIGTERM", false, true, true, "termination requested");
AddSignal(16, "SIGUSR1", false, true, true, "user defined signal 1");
AddSignal(17, "SIGUSR2", false, true, true, "user defined signal 2");
AddSignal(18, "SIGCHLD", false, false, true, "child status has changed", "SIGCLD");
AddSignal(19, "SIGPWR", false, true, true, "power failure");
AddSignal(20, "SIGWINCH", false, true, true, "window size changes");
AddSignal(21, "SIGURG", false, true, true, "urgent data on socket");
AddSignal(22, "SIGIO", false, true, true, "input/output ready/Pollable event", "SIGPOLL");
AddSignal(23, "SIGSTOP", true, true, true, "process stop");
AddSignal(24, "SIGTSTP", false, true, true, "tty stop");
AddSignal(25, "SIGCONT", false, false, true, "process continue");
AddSignal(26, "SIGTTIN", false, true, true, "background tty read");
AddSignal(27, "SIGTTOU", false, true, true, "background tty write");
AddSignal(28, "SIGVTALRM", false, true, true, "virtual time alarm");
AddSignal(29, "SIGPROF", false, false, false, "profiling time alarm");
AddSignal(30, "SIGXCPU", false, true, true, "CPU resource exceeded");
AddSignal(31, "SIGXFSZ", false, true, true, "file size limit exceeded");
AddSignal(32, "SIG32", false, false, false, "threading library internal signal 1");
AddSignal(33, "SIG33", false, false, false, "threading library internal signal 2");
AddSignal(34, "SIGRTMIN", false, false, false, "real time signal 0");
AddSignal(35, "SIGRTMIN+1", false, false, false, "real time signal 1");
AddSignal(36, "SIGRTMIN+2", false, false, false, "real time signal 2");
AddSignal(37, "SIGRTMIN+3", false, false, false, "real time signal 3");
AddSignal(38, "SIGRTMIN+4", false, false, false, "real time signal 4");
AddSignal(39, "SIGRTMIN+5", false, false, false, "real time signal 5");
AddSignal(40, "SIGRTMIN+6", false, false, false, "real time signal 6");
AddSignal(41, "SIGRTMIN+7", false, false, false, "real time signal 7");
AddSignal(42, "SIGRTMIN+8", false, false, false, "real time signal 8");
AddSignal(43, "SIGRTMIN+9", false, false, false, "real time signal 9");
AddSignal(44, "SIGRTMIN+10", false, false, false, "real time signal 10");
AddSignal(45, "SIGRTMIN+11", false, false, false, "real time signal 11");
AddSignal(46, "SIGRTMIN+12", false, false, false, "real time signal 12");
AddSignal(47, "SIGRTMIN+13", false, false, false, "real time signal 13");
AddSignal(48, "SIGRTMIN+14", false, false, false, "real time signal 14");
AddSignal(49, "SIGRTMIN+15", false, false, false, "real time signal 15");
AddSignal(50, "SIGRTMAX-14", false, false, false, "real time signal 16"); // switching to SIGRTMAX-xxx to match "kill -l" output
AddSignal(51, "SIGRTMAX-13", false, false, false, "real time signal 17");
AddSignal(52, "SIGRTMAX-12", false, false, false, "real time signal 18");
AddSignal(53, "SIGRTMAX-11", false, false, false, "real time signal 19");
AddSignal(54, "SIGRTMAX-10", false, false, false, "real time signal 20");
AddSignal(55, "SIGRTMAX-9", false, false, false, "real time signal 21");
AddSignal(56, "SIGRTMAX-8", false, false, false, "real time signal 22");
AddSignal(57, "SIGRTMAX-7", false, false, false, "real time signal 23");
AddSignal(58, "SIGRTMAX-6", false, false, false, "real time signal 24");
AddSignal(59, "SIGRTMAX-5", false, false, false, "real time signal 25");
AddSignal(60, "SIGRTMAX-4", false, false, false, "real time signal 26");
AddSignal(61, "SIGRTMAX-3", false, false, false, "real time signal 27");
AddSignal(62, "SIGRTMAX-2", false, false, false, "real time signal 28");
AddSignal(63, "SIGRTMAX-1", false, false, false, "real time signal 29");
AddSignal(64, "SIGRTMAX", false, false, false, "real time signal 30");
// clang-format on
}

lldb/source/Target/UnixSignals.cpp

//===-- UnixSignals.cpp ---------------------------------------------------===// //===-- UnixSignals.cpp ---------------------------------------------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "lldb/Target/UnixSignals.h" #include "lldb/Target/UnixSignals.h"
#include "Plugins/Process/Utility/FreeBSDSignals.h" #include "Plugins/Process/Utility/FreeBSDSignals.h"
#include "Plugins/Process/Utility/LinuxSignals.h" #include "Plugins/Process/Utility/LinuxSignals.h"
#include "Plugins/Process/Utility/MipsLinuxSignals.h"
#include "Plugins/Process/Utility/NetBSDSignals.h" #include "Plugins/Process/Utility/NetBSDSignals.h"
#include "lldb/Host/HostInfo.h" #include "lldb/Host/HostInfo.h"
#include "lldb/Utility/ArchSpec.h" #include "lldb/Utility/ArchSpec.h"
#include <optional> #include <optional>
using namespace lldb_private; using namespace lldb_private;
using namespace llvm; using namespace llvm;
UnixSignals::Signal::Signal(const char *name, bool default_suppress, UnixSignals::Signal::Signal(const char *name, bool default_suppress,
bool default_stop, bool default_notify, bool default_stop, bool default_notify,
const char *description, const char *alias) const char *description, const char *alias)
: m_name(name), m_alias(alias), m_description(), : m_name(name), m_alias(alias), m_description(),
m_suppress(default_suppress), m_stop(default_stop), m_suppress(default_suppress), m_stop(default_stop),
m_notify(default_notify), m_notify(default_notify),
m_default_suppress(default_suppress), m_default_stop(default_stop), m_default_suppress(default_suppress), m_default_stop(default_stop),
m_default_notify(default_notify) { m_default_notify(default_notify) {
if (description) if (description)
m_description.assign(description); m_description.assign(description);
} }
lldb::UnixSignalsSP UnixSignals::Create(const ArchSpec &arch) { lldb::UnixSignalsSP UnixSignals::Create(const ArchSpec &arch) {
const auto &triple = arch.GetTriple(); const auto &triple = arch.GetTriple();
switch (triple.getOS()) { switch (triple.getOS()) {
case llvm::Triple::Linux: { case llvm::Triple::Linux:
switch (triple.getArch()) {
case llvm::Triple::mips:
case llvm::Triple::mipsel:
case llvm::Triple::mips64:
case llvm::Triple::mips64el:
return std::make_shared<MipsLinuxSignals>();
default:
return std::make_shared<LinuxSignals>(); return std::make_shared<LinuxSignals>();
}
}
case llvm::Triple::FreeBSD: case llvm::Triple::FreeBSD:
case llvm::Triple::OpenBSD: case llvm::Triple::OpenBSD:
return std::make_shared<FreeBSDSignals>(); return std::make_shared<FreeBSDSignals>();
case llvm::Triple::NetBSD: case llvm::Triple::NetBSD:
return std::make_shared<NetBSDSignals>(); return std::make_shared<NetBSDSignals>();
default: default:
return std::make_shared<UnixSignals>(); return std::make_shared<UnixSignals>();
} }
▲ Show 20 Lines • Show All 300 Lines • Show Last 20 Lines

llvm/utils/gn/secondary/lldb/source/Plugins/Process/Utility/BUILD.gn

Show All 21 Lines sources = [
"FreeBSDSignals.cpp", "FreeBSDSignals.cpp",
"GDBRemoteSignals.cpp", "GDBRemoteSignals.cpp",
"HistoryThread.cpp", "HistoryThread.cpp",
"HistoryUnwind.cpp", "HistoryUnwind.cpp",
"InferiorCallPOSIX.cpp", "InferiorCallPOSIX.cpp",
"LinuxProcMaps.cpp", "LinuxProcMaps.cpp",
"LinuxSignals.cpp", "LinuxSignals.cpp",
"MemoryTagManagerAArch64MTE.cpp", "MemoryTagManagerAArch64MTE.cpp",
"MipsLinuxSignals.cpp",
"NativeProcessSoftwareSingleStep.cpp", "NativeProcessSoftwareSingleStep.cpp",
"NativeRegisterContextDBReg_arm64.cpp", "NativeRegisterContextDBReg_arm64.cpp",
"NativeRegisterContextDBReg_x86.cpp", "NativeRegisterContextDBReg_x86.cpp",
"NativeRegisterContextRegisterInfo.cpp", "NativeRegisterContextRegisterInfo.cpp",
"NetBSDSignals.cpp", "NetBSDSignals.cpp",
"RegisterContextDarwin_arm.cpp", "RegisterContextDarwin_arm.cpp",
"RegisterContextDarwin_arm64.cpp", "RegisterContextDarwin_arm64.cpp",
"RegisterContextDarwin_i386.cpp", "RegisterContextDarwin_i386.cpp",
Show All 40 Lines
lldb/source/Plugins/Process/Utility/MipsLinuxSignals.h