This is an archive of the discontinued LLVM Phabricator instance.

Differential D145731

[mlir][vector] remove unnecessary VectorTransformOps include
ClosedPublic

Authored by cota on Mar 9 2023, 2:09 PM.

Details

Reviewers
kuhar
aartbik
nicolasvasilache
dcaballe
Commits
rG350d7e33ff09: [mlir][vector] remove unnecessary VectorTransformOps include
Summary

While at it, add a dep that we missed in https://reviews.llvm.org/D145638.

Diff Detail

Event Timeline

cota created this revision.Mar 9 2023, 2:09 PM
Herald added a reviewer: aartbik. · View Herald TranscriptMar 9 2023, 2:09 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
cota requested review of this revision.Mar 9 2023, 2:09 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 9 2023, 2:09 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
kuhar accepted this revision.Mar 9 2023, 2:12 PM

Thanks!

This revision is now accepted and ready to land.Mar 9 2023, 2:12 PM
dcaballe accepted this revision.Mar 9 2023, 2:55 PM

Thanks!

This revision was landed with ongoing or failed builds.Mar 9 2023, 3:24 PM
Closed by commit rG350d7e33ff09: [mlir][vector] remove unnecessary VectorTransformOps include (authored by cota). · Explain Why
This revision was automatically updated to reflect the committed changes.
cota added a commit: rG350d7e33ff09: [mlir][vector] remove unnecessary VectorTransformOps include.
Harbormaster completed remote builds in B218517: Diff 503932.Mar 9 2023, 4:04 PM

Revision Contents

PathSize
mlir/
lib/
Dialect/
Vector/
Transforms/
1 line
test/
lib/
Dialect/
Vector/
1 line
utils/
bazel/
llvm-project-overlay/
mlir/
test/
1 line

Diff 503951

mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp

Show All 19 Lines
#include "mlir/Dialect/Arith/IR/Arith.h" #include "mlir/Dialect/Arith/IR/Arith.h"
#include "mlir/Dialect/Arith/Utils/Utils.h" #include "mlir/Dialect/Arith/Utils/Utils.h"
#include "mlir/Dialect/Linalg/IR/Linalg.h" #include "mlir/Dialect/Linalg/IR/Linalg.h"
#include "mlir/Dialect/MemRef/IR/MemRef.h" #include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/SCF/IR/SCF.h" #include "mlir/Dialect/SCF/IR/SCF.h"
#include "mlir/Dialect/Utils/IndexingUtils.h" #include "mlir/Dialect/Utils/IndexingUtils.h"
#include "mlir/Dialect/Utils/StructuredOpsUtils.h" #include "mlir/Dialect/Utils/StructuredOpsUtils.h"
#include "mlir/Dialect/Vector/IR/VectorOps.h" #include "mlir/Dialect/Vector/IR/VectorOps.h"
#include "mlir/Dialect/Vector/TransformOps/VectorTransformOps.h"
#include "mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h" #include "mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h"
#include "mlir/Dialect/Vector/Utils/VectorUtils.h" #include "mlir/Dialect/Vector/Utils/VectorUtils.h"
#include "mlir/IR/BuiltinAttributeInterfaces.h" #include "mlir/IR/BuiltinAttributeInterfaces.h"
#include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/BuiltinTypes.h"
#include "mlir/IR/ImplicitLocOpBuilder.h" #include "mlir/IR/ImplicitLocOpBuilder.h"
#include "mlir/IR/Matchers.h" #include "mlir/IR/Matchers.h"
#include "mlir/IR/PatternMatch.h" #include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/VectorInterfaces.h" #include "mlir/Interfaces/VectorInterfaces.h"
▲ Show 20 Lines • Show All 3,222 Lines • Show Last 20 Lines

mlir/test/lib/Dialect/Vector/CMakeLists.txt

# Exclude tests from libMLIR.so # Exclude tests from libMLIR.so
add_mlir_library(MLIRVectorTestPasses add_mlir_library(MLIRVectorTestPasses
TestVectorTransforms.cpp TestVectorTransforms.cpp
EXCLUDE_FROM_LIBMLIR EXCLUDE_FROM_LIBMLIR
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineDialect MLIRAffineDialect
MLIRAnalysis MLIRAnalysis
MLIRArithDialect
MLIRFuncDialect MLIRFuncDialect
MLIRGPUOps MLIRGPUOps
MLIRLinalgDialect MLIRLinalgDialect
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRLLVMDialect MLIRLLVMDialect
MLIRMemRefDialect MLIRMemRefDialect
MLIRPass MLIRPass
MLIRSCFDialect MLIRSCFDialect
MLIRTransformUtils MLIRTransformUtils
MLIRVectorDialect MLIRVectorDialect
MLIRVectorToSCF MLIRVectorToSCF
MLIRX86VectorDialect MLIRX86VectorDialect
) )

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

Show First 20 Lines • Show All 820 Lines • ▼ Show 20 Lines
cc_library( cc_library(
name = "TestVector", name = "TestVector",
srcs = glob(["lib/Dialect/Vector/*.cpp"]), srcs = glob(["lib/Dialect/Vector/*.cpp"]),
defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"], defines = ["MLIR_CUDA_CONVERSIONS_ENABLED"],
includes = ["lib/Dialect/Test"], includes = ["lib/Dialect/Test"],
deps = [ deps = [
"//mlir:AffineDialect", "//mlir:AffineDialect",
"//mlir:Analysis", "//mlir:Analysis",
"//mlir:ArithDialect",
"//mlir:FuncDialect", "//mlir:FuncDialect",
"//mlir:GPUDialect", "//mlir:GPUDialect",
"//mlir:LLVMDialect", "//mlir:LLVMDialect",
"//mlir:LinalgDialect", "//mlir:LinalgDialect",
"//mlir:LinalgTransforms", "//mlir:LinalgTransforms",
"//mlir:MemRefDialect", "//mlir:MemRefDialect",
"//mlir:Pass", "//mlir:Pass",
"//mlir:SCFDialect", "//mlir:SCFDialect",
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines