[HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

[tra]

clang should pass -mno-amdgpu-ieee to -cc1

It would be useful to have some details on why we should pass that option.

clang/test/Driver/hip-options.hip

133

Nit: Both lines could be collapsed into matching "-m{{(no-)?}}amdgpu-ieee" Either way is fine.

137–138

This looks odd.
If the DAG line matches on the first clang invocation, the NEG-NOT will always succeed, because it will have nothing to check.

If clang invocation with -no-mamdgpu-ieee happens to be before the invocation with -mamdgpu-ieee, then the NEG-NOT will not succeed.

Do I understand it correctly that the idea here is to make sure that only -mno-amdgpu-ieee is ever passed to cc1?
What's the purpose of -DAG? Do you expect to see multiple cc1 with "-triple" "amdgcn-amd-amdhsa" ? AFAICT there should be only one for gfx906 and DAG should not be needed.

The -NOT check I'd do in a separate RUN.

[yaxunl]

In D145721#4182834, @tra wrote:

clang should pass -mno-amdgpu-ieee to -cc1

It would be useful to have some details on why we should pass that option.

-mamdgpu-ieee was introduced by https://reviews.llvm.org/D77013 but I forgot to let clang driver pass it to clang -cc1. Recently we found that.

clang/test/Driver/hip-options.hip

133

will do

137–138

The -NEG check is supposed to be a separate run. I will add a separate run for it and remove -DAG

[yaxunl]

fix tests

clang/lib/Driver/ToolChains/Clang.cpp

if (IsOpenMPDevice) {
     }
   }
 
   if (Triple.isAMDGPU()) {
     handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs);
 
     Args.addOptInFlag(CmdArgs, options::OPT_munsafe_fp_atomics,
                       options::OPT_mno_unsafe_fp_atomics);
+    Args.addOptOutFlag(CmdArgs, options::OPT_mamdgpu_ieee,
+                       options::OPT_mno_amdgpu_ieee);
   }
 
   // For all the host OpenMP offloading compile jobs we need to pass the targets
   // information using -fopenmp-targets= option.
   if (JA.isHostOffloading(Action::OFK_OpenMP)) {
     SmallString<128> Targets("-fopenmp-targets=");
 
     SmallVector<std::string, 4> Triples;

clang/test/Driver/hip-options.hip

 // RUN:   --offload-arch=gfx906 -fhip-kernel-arg-name %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=KAN %s
 // KAN: "-cc1"{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fhip-kernel-arg-name"
 
 // RUN: %clang -### --target=x86_64-unknown-linux-gnu -nogpuinc -nogpulib \
 // RUN:   --offload-arch=gfx906 %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=KANNEG %s
 // KANNEG-NOT: "-fhip-kernel-arg-name"
+
+// RUN: %clang -### -nogpuinc -nogpulib -mno-amdgpu-ieee -mamdgpu-ieee \
+// RUN:   --cuda-gpu-arch=gfx906  %s 2>&1 | FileCheck -check-prefix=IEEE-ON %s
+// IEEE-ON-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mamdgpu-ieee"
+// IEEE-ON-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mno-amdgpu-ieee"
+
+// RUN: %clang -### -nogpuinc -nogpulib -mamdgpu-ieee -mno-amdgpu-ieee -ffast-math \
+// RUN:   --cuda-gpu-arch=gfx906  %s 2>&1 | FileCheck -check-prefixes=IEEE-OFF,IEEE-OFF-NEG %s
+// IEEE-OFF-NEG-NOT: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mamdgpu-ieee"
+// IEEE-OFF-DAG: clang{{.*}} "-triple" "amdgcn-amd-amdhsa" {{.*}} "-mno-amdgpu-ieee"