[mlir] Relaxing verification of DPS ops

[vmurali]

Summary

Previously the tied operand and result operand had to match ShapedType exactly. I am relaxing it to allow dynamic shapes on one side and static shapes on the other, as some Linalg Transformations (like Padding) creates dynamic shapes. The rationale is that a dynamic dimension can be potentially unified with any dimension value.

[vmurali]

Fixed another bug

[hanchung]

I'm not convinced that this is the fix... The result type and operand type should match based on my understanding about DPS interface. (I could be wrong though)

[vmurali]

In D145625#4179676, @hanchung wrote:

I'm not convinced that this is the fix... The result type and operand type should match based on my understanding about DPS interface. (I could be wrong though)

The latest padding transformation https://github.com/llvm/llvm-project/commit/6d2501bf00f662ef05731aa7c59351467aac2a70 creates dynamic types. So @nicolasvasilache can chime in and fix it correctly?

[nicolasvasilache]

shapes need to match, I am unclear why you need this and why there is no clear test that exercises such fundamental changes

[nicolasvasilache]

@pifon2a for visibility

[vmurali]

Closing this as the bug is somewhere else

mlir/lib/Interfaces/DestinationStyleOpInterface.cpp

LogicalResult detail::verifyDestinationStyleOpInterface(Operation *op) {
   if (op->getNumResults() != outputTensorOperands.size())
     return op->emitOpError("expected the number of results (")
            << op->getNumResults()
            << ") to be equal to the number of output tensors ("
            << outputTensorOperands.size() << ")";
 
   for (OpOperand *opOperand : outputTensorOperands) {
     OpResult result = dstStyleOp.getTiedOpResult(opOperand);
-    if (result.getType() != opOperand->get().getType())
+    if (result.getType().cast<ShapedType>().getShape().size() !=
+        opOperand->get().getType().cast<ShapedType>().getShape().size()) {
       return op->emitOpError("expected type of operand #")
              << opOperand->getOperandNumber() << " ("
              << opOperand->get().getType() << ")"
              << " to match type of corresponding result (" << result.getType()
              << ")";
     }
+    for (auto [resD, opD] : llvm::zip_equal(
+      result.getType().cast<ShapedType>().getShape(),
+      opOperand->get().getType().cast<ShapedType>().getShape())) {
+        if (resD == opD || resD == ShapedType::kDynamic ||
+            opD == ShapedType::kDynamic)
+          continue;
+        return op->emitOpError("expected type of operand #")
+               << opOperand->getOperandNumber() << " ("
+               << opOperand->get().getType() << ")"
+               << " to match type of corresponding result (" << result.getType()
+               << ")";
+    }
+  }
+
   return success();
 }