Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
133 | De-duplicates? | |
586 | const? also, just spell out the type? | |
762 | typo: level | |
790 | same? | |
914 | fast forward (no s) | |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h | ||
193 | a non-unique (no an) | |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
1452–1453 | maybe move this TODO:sort into the loop emitter, since it is probably going to be inserted there? |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
586 | You are right, I reverted it. (It is left from some experimental change that I did not fully revert) |
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_coo_test.mlir | ||
---|---|---|
175 | Why do I need to free the dense return here? @springerm |
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp | ||
---|---|---|
764 | it almost feels you can do this unconditionally, since it won't be set if not unique |
a non-unique (no an)
to fast forward (missing r)