Also add a helpful message that mlir-opt continues with normal processing to
avoid folks waiting while mlir-opt is stuck on stdin.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/test/mlir-opt/commandline.mlir | ||
---|---|---|
43 | Actually the help message won't work here, I need more work on the refactoring... |
mlir/test/mlir-opt/commandline.mlir | ||
---|---|---|
1 | It's actually quite interesting that this test works. For us internally, this is the one that break (I first assumed that it was some internal test, but it's actually this upstream test that hangs). Maybe a different way of running lit is causing this. But it would be much nicer if the run line was echo "" | mlir-opt --show-dialects | FileCheck %s to make sure it finishes. |
mlir/test/mlir-opt/commandline.mlir | ||
---|---|---|
1 | FYI, submitted: https://github.com/llvm/llvm-project/commit/f2cdccc034d0696f186f55d6826dd6ac40e4d3d5 that adds echo. |
mlir/test/mlir-opt/commandline.mlir | ||
---|---|---|
1 | I suspect you have some downstream specific runner that don't close stdin properly. |
mlir/test/mlir-opt/commandline.mlir | ||
---|---|---|
1 |
See this thread: https://discourse.llvm.org/t/lit-runner-passing-empty-stdin-to-tool-makes-incorrect-tests-pass/65672 |
It's actually quite interesting that this test works. For us internally, this is the one that break (I first assumed that it was some internal test, but it's actually this upstream test that hangs). Maybe a different way of running lit is causing this. But it would be much nicer if the run line was echo "" | mlir-opt --show-dialects | FileCheck %s to make sure it finishes.