[clang-tidy] altera-id-dependent-backward-branch: do not mark all variables
Needs ReviewPublic
Actions

Authored by yeputons-gh on Mar 4 2023, 3:32 AM.

Details

Reviewers

njames93
aaron.ballman

Summary

Mark variables/fields as ID-dependent when initializing from ID-dependent
expressions only, not any expressions.

Fixes https://github.com/llvm/llvm-project/issues/52790

Depends on D145304

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

yeputons-gh created this revision.Mar 4 2023, 3:32 AM

Herald added a reviewer: njames93. · View Herald TranscriptMar 4 2023, 3:32 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: carlosgalvezp. · View Herald Transcript

yeputons-gh requested review of this revision.Mar 4 2023, 3:32 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2023, 3:32 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

yeputons-gh edited the summary of this revision. (Show Details)Mar 4 2023, 3:33 AM

Harbormaster completed remote builds in B217363: Diff 502366.Mar 4 2023, 3:54 AM

Applied clang-format to the header as well

Harbormaster completed remote builds in B217365: Diff 502372.Mar 4 2023, 6:44 AM

Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp.Mar 4 2023, 7:15 AM

yeputons-gh added inline comments.Mar 4 2023, 9:38 AM

clang-tools-extra/test/clang-tidy/checkers/altera/id-dependent-backward-branch.cpp
128	This line previously yielded a false positive. Now it does not. More tests are created in upcoming patches.

yeputons-gh retitled this revision from clang-tidy altera-id-dependent-backward-branch: fix #52790 to [clang-tidy] altera-id-dependent-backward-branch: fix #52790.Mar 5 2023, 9:44 AM

Herald added a subscriber: xazax.hun. · View Herald TranscriptMar 5 2023, 9:44 AM

yeputons-gh retitled this revision from [clang-tidy] altera-id-dependent-backward-branch: fix #52790 to [clang-tidy] altera-id-dependent-backward-branch: do not mark all variables.Mar 5 2023, 9:45 AM

Rebased on top of the recent main.

yeputons-gh added a child revision: D145321: [clang-tidy] altera-id-dependent-backward-branch: fix assignment notes.Mar 5 2023, 10:06 AM

Harbormaster completed remote builds in B217428: Diff 502445.Mar 5 2023, 10:24 AM

carlosgalvezp removed a reviewer: carlosgalvezp.Mar 18 2023, 9:48 AM

Herald added a subscriber: PiotrZSL. · View Herald TranscriptMar 18 2023, 9:48 AM