This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Assume that coroutines are available in C++20
ClosedPublic

Authored by ldionne on Mar 1 2023, 10:33 AM.

Details

Summary

All supported compilers have support for coroutines in C++20 now.

Diff Detail

Event Timeline

ldionne created this revision.Mar 1 2023, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 10:33 AM
ldionne requested review of this revision.Mar 1 2023, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 10:33 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Mar 1 2023, 10:36 AM
This revision is now accepted and ready to land.Mar 1 2023, 10:36 AM

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Yeah, it does look like the latest supported AppleClang doesn't work out of the box. Let's wait a bit before landing this.

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Yeah, it does look like the latest supported AppleClang doesn't work out of the box. Let's wait a bit before landing this.

That indeed matches my experience. I just abandoned my patch in favour of this one.

Mordante accepted this revision.Mar 3 2023, 9:12 AM
ldionne updated this revision to Diff 548174.Aug 8 2023, 5:44 AM

Rebase on top of modular build fixes (hopefully).

ldionne added a comment.EditedAug 8 2023, 11:05 AM

This works now, only the AIX build failed so I'll ship this.

(Edit: I think this must have started working when I updated the last AppleClang builders recently)

This revision was landed with ongoing or failed builds.Aug 8 2023, 11:06 AM
This revision was automatically updated to reflect the committed changes.