Page MenuHomePhabricator
Differential D145086

[libc++] Assume that coroutines are available in C++20
AcceptedPublic
Actions

Authored by ldionne on Wed, Mar 1, 10:33 AM.

Details

Reviewers
philnik
Mordante
Group Reviewers
Restricted Project
Summary

All supported compilers have support for coroutines in C++20 now.

Diff Detail

Unit TestsFailed
View All

TimeTest
510 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/coroutine_handle/coroutine_handle_prom::promise.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/Output/promise.pass.cpp.dir/t.tmp.exe
270 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::await_result.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/await_result.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/await_result.pass.cpp.dir/t.tmp.exe
270 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::bool_await_suspend.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/bool_await_suspend.pass.cpp.dir/t.tmp.exe
560 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::expected.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/expected.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/expected.pass.cpp.dir/t.tmp.exe
260 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::fullexpr-dtor.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/fullexpr-dtor.pass.cpp.dir/t.tmp.exe
View Full Test Results (63 Failed)

Event Timeline

ldionne created this revision.Wed, Mar 1, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 10:33 AM
Herald added subscribers: ChuanqiXu, arichardson. · View Herald Transcript
ldionne requested review of this revision.Wed, Mar 1, 10:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 10:33 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Wed, Mar 1, 10:36 AM
This revision is now accepted and ready to land.Wed, Mar 1, 10:36 AM
Mordante added a subscriber: Mordante.Wed, Mar 1, 10:45 AM

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Harbormaster completed remote builds in B216768: Diff 501572.Wed, Mar 1, 10:55 AM
ldionne updated this revision to Diff 501630.Wed, Mar 1, 12:23 PM

Rebase

ldionne added a comment.Wed, Mar 1, 12:23 PM
In D145086#4162218, @Mordante wrote:

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Harbormaster completed remote builds in B216808: Diff 501630.Wed, Mar 1, 1:55 PM
ldionne added a comment.Thu, Mar 2, 9:40 AM
In D145086#4162687, @ldionne wrote:
In D145086#4162218, @Mordante wrote:

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Yeah, it does look like the latest supported AppleClang doesn't work out of the box. Let's wait a bit before landing this.

Mordante mentioned this in D143485: [libc++] Updates coroutine status..Fri, Mar 3, 9:10 AM
In D145086#4164994, @ldionne wrote:
In D145086#4162687, @ldionne wrote:
In D145086#4162218, @Mordante wrote:

Are you sure all CIs have this available? I tried about a month ago and ran into CI issues, see D143485.

Interesting, let's see what the CI thinks this time around.

Yeah, it does look like the latest supported AppleClang doesn't work out of the box. Let's wait a bit before landing this.

That indeed matches my experience. I just abandoned my patch in favour of this one.

Mordante accepted this revision.Fri, Mar 3, 9:12 AM

Revision Contents
Changeset List

PathSize
libcxx/
docs/
DesignDocs/
2 lines
test/
libcxx/
assertions/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
std/
language.support/
support.coroutines/
coroutine.handle/
coroutine.handle.hash/
1 line
coroutine.handle.capacity/
1 line
coroutine.handle.compare/
1 line
1 line
coroutine.handle.completion/
1 line
coroutine.handle.con/
1 line
1 line
coroutine.handle.export/
1 line
1 line
coroutine.handle.noop/
1 line
coroutine.handle.prom/
1 line
coroutine.handle.resumption/
1 line
1 line
1 line
coroutine.traits/
1 line
coroutine.trivial.awaitables/
1 line
1 line
end.to.end/
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
utils/
3 lines
libcxx/
test/
1 line

Diff 501630

View Options

libcxx/docs/DesignDocs/ExperimentalFeatures.rst

Loading...
View Options

libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp

Loading...
View Options

libcxx/test/libcxx/clang_tidy.sh.cpp

Loading...
View Options

libcxx/test/libcxx/double_include.sh.cpp

Loading...
View Options

libcxx/test/libcxx/min_max_macros.compile.pass.cpp

Loading...
View Options

libcxx/test/libcxx/modules_include.sh.cpp

Loading...
View Options

libcxx/test/libcxx/nasty_macros.compile.pass.cpp

Loading...
View Options

libcxx/test/libcxx/no_assert_include.compile.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.hash/hash.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.capacity/operator_bool.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/equal_comp.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/less_comp.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.completion/done.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/assign.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/construct.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/address.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/from_address.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.noop/noop_coroutine.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/destroy.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/resume.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/void_handle.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.traits/promise_type.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_always.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_never.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/await_result.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/expected.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/generator.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/go.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp

Loading...
View Options

libcxx/utils/generate_header_tests.py

Loading...
View Options

libcxx/utils/libcxx/test/features.py

Loading...