Page MenuHomePhabricator
Differential D143485

[libc++] Updates coroutine status.
AbandonedPublicDraft
Actions

Authored by Mordante on Feb 7 2023, 3:01 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

All supported compilers support coroutines so remove the test features.
Drive-by update the documentation to mention the experimental support
has been removed.

Diff Detail

Unit TestsFailed
View All

TimeTest
490 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/coroutine_handle/coroutine_handle_prom::promise.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/Output/promise.pass.cpp.dir/t.tmp.exe
290 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::await_result.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/await_result.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/await_result.pass.cpp.dir/t.tmp.exe
270 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::bool_await_suspend.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/bool_await_suspend.pass.cpp.dir/t.tmp.exe
530 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::expected.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/expected.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/expected.pass.cpp.dir/t.tmp.exe
240 mslibcxx CI Apple back-deployment macosx10.15 > apple-libc++-backdeployment-cfg-in.std/language_support/support_coroutines/end_to_end::fullexpr-dtor.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/std/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=x86_64-apple-macosx10.15 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com/llvm-project/libcxx-ci/build/apple-system-backdeployment-10.15/test/std/language.support/support.coroutines/end.to.end/Output/fullexpr-dtor.pass.cpp.dir/t.tmp.exe
View Full Test Results (55 Failed)

Event Timeline

Mordante created this revision.Feb 7 2023, 3:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 3:01 AM
Herald added subscribers: ChuanqiXu, arichardson. · View Herald Transcript
Harbormaster completed remote builds in B212328: Diff 495448.Feb 7 2023, 6:05 AM
Mordante mentioned this in D145086: [libc++] Assume that coroutines are available in C++20.Wed, Mar 1, 10:45 AM
Mordante abandoned this revision.Fri, Mar 3, 9:10 AM

It seems D145086 removes more, so abandoning this revision in favour to that one.

Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 3, 9:10 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript

Revision Contents
Changeset List

PathSize
libcxx/
docs/
DesignDocs/
2 lines
test/
std/
language.support/
support.coroutines/
coroutine.handle/
coroutine.handle.hash/
1 line
coroutine.handle.capacity/
1 line
coroutine.handle.compare/
1 line
1 line
coroutine.handle.completion/
1 line
coroutine.handle.con/
1 line
1 line
coroutine.handle.export/
1 line
1 line
coroutine.handle.noop/
1 line
coroutine.handle.prom/
1 line
coroutine.handle.resumption/
1 line
1 line
1 line
coroutine.traits/
1 line
coroutine.trivial.awaitables/
1 line
1 line
end.to.end/
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
utils/
libcxx/
test/
1 line

Diff 495448

View Options

libcxx/docs/DesignDocs/ExperimentalFeatures.rst

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.hash/hash.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.capacity/operator_bool.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/equal_comp.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.compare/less_comp.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.completion/done.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/assign.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.con/construct.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/address.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.export/from_address.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.noop/noop_coroutine.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/destroy.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/coroutine.handle.resumption/resume.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.handle/void_handle.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.traits/promise_type.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_always.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/coroutine.trivial.awaitables/suspend_never.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/await_result.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/expected.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/generator.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/go.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp

Loading...
View Options

libcxx/test/std/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp

Loading...
View Options

libcxx/utils/libcxx/test/features.py

Loading...