This is an archive of the discontinued LLVM Phabricator instance.

Driver: introduce GNU spellings to control MSVC paths
ClosedPublic

Authored by compnerd on Feb 28 2023, 2:24 PM.

Details

Summary

Add a set of -Xmicrosoft flags to control the Windows SDK and VisualC
tools directories. This allows control over the selection of the SDK
and tools when using the GNU driver.

Diff Detail

Event Timeline

compnerd created this revision.Feb 28 2023, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 2:24 PM
compnerd requested review of this revision.Feb 28 2023, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 2:24 PM

Looks reasonable to me, adding a few others for opinions. Should we have some tests for this? I guess testing these is somewhat environment reliant though, so it's probably not so easy...

Yeah, I suspect that would be difficult. Additionally, these are aliases, so they should already have testing coverage through the existing tests.

Just a friendly reminder, I'd like to get this merged to do a follow up change to improve some of the usability of these flags.

mstorsjo accepted this revision.Mar 6 2023, 2:01 PM

If others don't have anything to add on this matter, I guess this is fine.

The new option names feel rather wordy and unwieldy (especially compared to the clang-cl forms they're aliases for), so if you would want to consider a slightly shorter form, that would also be fine with me. But I won't object to this form either.

This revision is now accepted and ready to land.Mar 6 2023, 2:01 PM
This revision was landed with ongoing or failed builds.Mar 7 2023, 8:42 AM
This revision was automatically updated to reflect the committed changes.