Page MenuHomePhabricator

zahen (Zachary Henkel)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2018, 6:10 PM (40 w, 3 d)

Recent Activity

Tue, Sep 17

zahen added a comment to D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..

I just checked a trivial mismatch example in clang 8.0 (https://godbolt.org/z/wiSAp6) and I missed how the compatibility mode operates. I withdraw my suggestion since the patch keeps consistency with the existing behavior. Thanks for the -Werror=microsoft-exception-spec suggestion that's exactly what our project wants.

Tue, Sep 17, 8:42 AM · Restricted Project, Restricted Project
zahen added a comment to D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode..

Is there any interest in supporting the cl.exe flag /permissive-? I considered a hard error on mismatched exception specifier in clang-cl a feature, not a bug. If msvc compat mode respected that flag this could continue to be an error with that flag set (and upgraded strictness in other cases).

Tue, Sep 17, 8:05 AM · Restricted Project, Restricted Project

Thu, Sep 12

zahen abandoned D62752: Move VarBypassDector.h to include/clang/CodeGen.
Thu, Sep 12, 9:14 AM · Restricted Project

May 31 2019

zahen created D62752: Move VarBypassDector.h to include/clang/CodeGen.
May 31 2019, 2:52 PM · Restricted Project

Jan 24 2019

zahen created D57189: Fix compatibility with the msvc AI compiler option.
Jan 24 2019, 1:46 PM

Jan 8 2019

zahen added a comment to D55769: Add support for demangling msvc's noexcept types to llvm-undname.

lgtm. I'm technically on vacation so rnk@ might be able to commit it sooner than I can, but if he doesn't, then I'll commit it when I find some spare cycles. Thanks for fixing this!

Jan 8 2019, 11:26 AM

Dec 17 2018

zahen added a comment to D55769: Add support for demangling msvc's noexcept types to llvm-undname.

Same as the corresponding mangling patch, I'd appreciate someone else landing this since I don't have check-in permission.

Dec 17 2018, 3:19 PM
zahen added a comment to D55685: Update Microsoft name mangling scheme for exception specifiers in the type system.

I don't have check-in permission, so I'd appreciate if someone could handle the actual commit.

Dec 17 2018, 1:05 PM
zahen updated the diff for D55685: Update Microsoft name mangling scheme for exception specifiers in the type system.

Added support for msvc minor version as requested. Tied the updated mangling scheme to C++17 & compatibility mode > 1912 (15.5). Added additional tests.

Dec 17 2018, 10:21 AM
zahen created D55769: Add support for demangling msvc's noexcept types to llvm-undname.
Dec 17 2018, 8:07 AM

Dec 14 2018

zahen added a comment to D55685: Update Microsoft name mangling scheme for exception specifiers in the type system.

BTW, as far as updating the demangler, as long as it doesn't crash or generate an error on a valid _E mangling, that should be sufficient (with a test). If you want bonus points you can make it print out noexcept when you see the _E, but I won't require it as it's a bit of extra work. If you decide not to do that, I'll just file a bug for it so that we don't forget.

Dec 14 2018, 3:16 PM
zahen added a comment to D55685: Update Microsoft name mangling scheme for exception specifiers in the type system.

Also we still need to put this behind -fms-compatibility-version. Finally, it would be nice if you could also update the demangler (llvm/lib/Demangle/MicrosoftDemangle.cpp)

Dec 14 2018, 2:46 PM

Dec 13 2018

zahen created D55685: Update Microsoft name mangling scheme for exception specifiers in the type system.
Dec 13 2018, 6:19 PM