This is an archive of the discontinued LLVM Phabricator instance.

[Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.
ClosedPublic

Authored by craig.topper on Feb 28 2023, 10:50 AM.

Details

Summary

It appears that ICK_Zero_Queue_Conversion was inserted into the ICK
enum without updating this table. Easy to do since the table size
was set to ICK_Num_Conversion_Kinds.

I've used ICR_Exact_Match to match what was previously done for
ICK_Zero_Event_Conversion that last time someone noticed this had happened.

To prevent this from happening again, I've removed the explicit size
and used a static_assert to check the size against ICK_Num_Conversion_Kinds.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 28 2023, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 10:50 AM
craig.topper requested review of this revision.Feb 28 2023, 10:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 10:50 AM
aaron.ballman accepted this revision.Feb 28 2023, 11:08 AM

LGTM, good catch and nice solution!

This revision is now accepted and ready to land.Feb 28 2023, 11:08 AM
This revision was landed with ongoing or failed builds.Feb 28 2023, 11:17 AM
This revision was automatically updated to reflect the committed changes.