This is an archive of the discontinued LLVM Phabricator instance.

Add missing roundtointegral builtin functions for some FP instructions to be generated from C-written codes
ClosedPublic

Authored by joshua-arch1 on Feb 27 2023, 5:54 PM.

Details

Summary

To generate FROUND instructions in https://reviews.llvm.org/D143982, we need to use llvm intrinsics in IR files. Now I add some corresponding builtin functions to make sure these roundtointegral instructions can be generated from C codes.

Diff Detail

Event Timeline

joshua-arch1 created this revision.Feb 27 2023, 5:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2023, 5:54 PM
joshua-arch1 requested review of this revision.Feb 27 2023, 5:54 PM
joshua-arch1 retitled this revision from Add missing builtin functions for some FP instructions to be generated from C-written codes to Add missing roundtointegral builtin functions for some FP instructions to be generated from C-written codes.
efriedma accepted this revision.Feb 28 2023, 5:05 PM

LGTM. These are standard C23 functions, and glibc already has implementations; we should be recognizing them.

This revision is now accepted and ready to land.Feb 28 2023, 5:05 PM
This revision was landed with ongoing or failed builds.Mar 6 2023, 10:17 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 10:17 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript