Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td | ||
|---|---|---|
| 263 | indice -> index | |
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp | ||
| 1043 | I think it reads a bit easier if you swap if/else so // Fold the trivial conversion case.
if (retElemTp == srcElemTp && encDst == encSrc) {
rewriter.replaceOp(op, adaptor.getSource());
return success();
}
// BIt more documentation on your code
.... your new code
return success(); | |
Comment Actions
address comments.
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp | ||
|---|---|---|
| 1043 | Indeed it does! | |
| mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp | ||
|---|---|---|
| 1037 | please document the earlier two return cases more prominently // Different bitwidths should be handled by rewriting if () return failure // Fold trivial if () return success() // Your code | |
indice -> index