This is an archive of the discontinued LLVM Phabricator instance.

[C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode
ClosedPublic

Authored by usaxena95 on Feb 21 2023, 6:25 AM.

Diff Detail

Event Timeline

usaxena95 created this revision.Feb 21 2023, 6:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 6:25 AM
usaxena95 requested review of this revision.Feb 21 2023, 6:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 6:25 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gribozavr2 accepted this revision.Mar 2 2023, 3:17 AM
gribozavr2 added a subscriber: gribozavr2.
gribozavr2 added inline comments.
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-member-init-cxx98.cpp
2 ↗(On Diff #499146)

Please revert this unnecessary change.

clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h
113 ↗(On Diff #499146)

Could you break this out into a separate commit with a description like "change ClangTidy unit tests to run in C++20 mode instead of C++11". This is a change, not an extension ("also run in C++20").

This revision is now accepted and ready to land.Mar 2 2023, 3:17 AM
usaxena95 updated this revision to Diff 501822.Mar 2 2023, 4:02 AM
usaxena95 marked 2 inline comments as done.

Addressed comments.

This revision was landed with ongoing or failed builds.Mar 2 2023, 4:03 AM
This revision was automatically updated to reflect the committed changes.