This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Pre-commit test case for ordered reduction, NFC
ClosedPublic

Authored by Mel-Chen on Feb 21 2023, 1:34 AM.

Diff Detail

Event Timeline

Mel-Chen created this revision.Feb 21 2023, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 1:34 AM
Mel-Chen requested review of this revision.Feb 21 2023, 1:34 AM
reames accepted this revision.Feb 22 2023, 3:09 PM
reames added a subscriber: reames.

LGTM w/comment addressed before landing.

llvm/test/Transforms/LoopVectorize/RISCV/ordered-reduction.ll
3

Please add a check line for the configuration: -force-ordered-reductions=true -hints-allow-reordering=false.

This allows you to test the codegen for ordered reductions in this change and next becomes only changing which check prefixes one line uses.

This revision is now accepted and ready to land.Feb 22 2023, 3:09 PM
reames added inline comments.Feb 22 2023, 3:12 PM
llvm/test/Transforms/LoopVectorize/RISCV/ordered-reduction.ll
3

Also, this has nothing to do with your change, but the fact that -hints-allow-reordering defaults to true is deeply and unpleasantly surprising. That is *not* the semantics I'd have expected from the loop directives.

Mel-Chen updated this revision to Diff 500152.Feb 24 2023, 5:13 AM

Rebase and add test for -force-ordered-reductions=true -hints-allow-reordering=false.

Mel-Chen marked an inline comment as done.Feb 24 2023, 5:19 AM
Mel-Chen added inline comments.
llvm/test/Transforms/LoopVectorize/RISCV/ordered-reduction.ll
3

Yes, this is news to me, and also surprise me.

Mel-Chen updated this revision to Diff 501489.Mar 1 2023, 6:26 AM

Rebase and land.

This revision was landed with ongoing or failed builds.Mar 1 2023, 6:28 AM
This revision was automatically updated to reflect the committed changes.