This is an archive of the discontinued LLVM Phabricator instance.

Differential D144453

[clangd] Fix a bug in TweakTest::decorate()
ClosedPublic

Authored by nridge on Feb 21 2023, 12:25 AM.

Details

Reviewers
kadircet
hokein
sammccall
Commits
rGe9a88b6178d3: [clangd] Fix a bug in TweakTest::decorate()
Summary

The second argument to string::substr() is a count,
not an end position.

Diff Detail

Event Timeline

nridge created this revision.Feb 21 2023, 12:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 12:25 AM
Herald added a subscriber: arphaman. · View Herald Transcript
nridge requested review of this revision.Feb 21 2023, 12:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 12:25 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
Harbormaster completed remote builds in B214938: Diff 499056.Feb 21 2023, 1:16 AM
nridge added reviewers: hokein, sammccall.Mar 12 2023, 9:52 PM
hokein accepted this revision.Mar 13 2023, 3:39 AM

Good catch, thanks!

This revision is now accepted and ready to land.Mar 13 2023, 3:39 AM
Closed by commit rGe9a88b6178d3: [clangd] Fix a bug in TweakTest::decorate() (authored by nridge). · Explain WhyMar 14 2023, 12:02 AM
This revision was automatically updated to reflect the committed changes.
nridge added a commit: rGe9a88b6178d3: [clangd] Fix a bug in TweakTest::decorate().

Revision Contents

PathSize
clang-tools-extra/
clangd/
unittests/
tweaks/
3 lines

Diff 504960

clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines
std::string TweakTest::decorate(llvm::StringRef Code, unsigned Point) { std::string TweakTest::decorate(llvm::StringRef Code, unsigned Point) {
return (Code.substr(0, Point) + "^" + Code.substr(Point)).str(); return (Code.substr(0, Point) + "^" + Code.substr(Point)).str();
} }
std::string TweakTest::decorate(llvm::StringRef Code, std::string TweakTest::decorate(llvm::StringRef Code,
llvm::Annotations::Range Range) { llvm::Annotations::Range Range) {
return (Code.substr(0, Range.Begin) + "[[" + return (Code.substr(0, Range.Begin) + "[[" +
Code.substr(Range.Begin, Range.End) + "]]" + Code.substr(Range.End)) Code.substr(Range.Begin, Range.End - Range.Begin) + "]]" +
Code.substr(Range.End))
.str(); .str();
} }
} // namespace clangd } // namespace clangd
} // namespace clang } // namespace clang