Allows us to handle expressions like -(a * b) + c
Based on the examples from D144366 that gcc seems to get.
Paths
| Differential D144447
[Clang] Teach buildFMulAdd to peek through fneg to find fmul. ClosedPublic Authored by craig.topper on Feb 20 2023, 9:50 PM.
Details Summary Allows us to handle expressions like -(a * b) + c Based on the examples from D144366 that gcc seems to get.
Diff Detail
Event Timeline
craig.topper added inline comments.
This revision is now accepted and ready to land.Feb 23 2023, 6:25 AM This revision was landed with ongoing or failed builds.Feb 23 2023, 9:06 AM Closed by commit rG83cd4bea015f: [Clang] Teach buildFMulAdd to peek through fneg to find fmul. (authored by craig.topper). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 499885 clang/lib/CodeGen/CGExprScalar.cpp
clang/test/CodeGen/constrained-math-builtins.c
clang/test/CodeGen/fp-contract-pragma.cpp
|
If I'm reading this right it looks like the assert() wasn't needed before. Do we know why it was added in the first place?