This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Analysis] Guard data flow analysis from no block function
ClosedPublic

Authored by Lewuathe on Feb 19 2023, 9:57 PM.

Details

Summary

Foo analysis for testing the data flow analysis does not support the region without any block. Although that analysis is assumed to be used for testing purpose, it is generally better to be explicit about the scope the framework supports.

The original issue was reported here.
https://github.com/llvm/llvm-project/issues/60580

Diff Detail

Event Timeline

Lewuathe created this revision.Feb 19 2023, 9:57 PM
Lewuathe requested review of this revision.Feb 19 2023, 9:57 PM
Lewuathe updated this revision to Diff 498720.Feb 19 2023, 9:58 PM

Add a link to the original issue.

Lewuathe edited the summary of this revision. (Show Details)
springerm accepted this revision.Feb 21 2023, 5:37 AM
springerm added inline comments.
mlir/test/lib/Analysis/TestDataFlowFramework.cpp
99

nit: I think getBlocks().empty() is more efficient.

This revision is now accepted and ready to land.Feb 21 2023, 5:37 AM