This is an archive of the discontinued LLVM Phabricator instance.

Fix potential crash in Flang generateLLVMIR() when MLIR fails to translate to LLVM

Authored by mehdi_amini on Feb 18 2023, 10:26 PM.



This is pure code motion, to ensure that the check if we have a valid llvmModule
comes before trying to set option on this module.

Diff Detail

Event Timeline

mehdi_amini created this revision.Feb 18 2023, 10:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 18 2023, 10:26 PM
mehdi_amini requested review of this revision.Feb 18 2023, 10:26 PM
awarzynski accepted this revision.Feb 19 2023, 8:41 AM

LGTM, thanks for the fix Mehdi!

This revision is now accepted and ready to land.Feb 19 2023, 8:41 AM
This revision was landed with ongoing or failed builds.Feb 19 2023, 8:56 AM
This revision was automatically updated to reflect the committed changes.