This is an archive of the discontinued LLVM Phabricator instance.

[SCEV] Optimize FoldID
ClosedPublic

Authored by vitalybuka on Feb 18 2023, 1:25 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Feb 18 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 1:25 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
vitalybuka requested review of this revision.Feb 18 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 1:25 PM
vitalybuka edited reviewers, added: fhahn; removed: Florian.Feb 18 2023, 1:26 PM

fix rebase conflicts

another rebase conflict

clang-format

vitalybuka edited the summary of this revision. (Show Details)Feb 18 2023, 1:58 PM
vitalybuka edited the summary of this revision. (Show Details)Feb 18 2023, 2:02 PM
vitalybuka edited the summary of this revision. (Show Details)Feb 24 2023, 3:52 PM

This one still improves on top of D144382.

simplify

@fhahn
is there a reason not to commit this?

nikic added a comment.Mar 8 2023, 1:11 PM

I believe the idea behind FoldID was to allow extending it to other SCEV types in the future. That said, I don't think we have specific plans for this right now, so it may makes sense to specialize to the types we're currently interested in.

MaskRay accepted this revision.Jun 22 2023, 5:04 PM

LGTM.

This revision is now accepted and ready to land.Jun 22 2023, 5:04 PM
This revision was automatically updated to reflect the committed changes.