Page MenuHomePhabricator
Differential D144335

[SCEV] Optimize FoldID
Needs ReviewPublic
Actions

Authored by vitalybuka on Feb 18 2023, 1:25 PM.

Details

Reviewers
nikic
fhahn
MaskRay
Summary

Improve compile time

https://llvm-compile-time-tracker.com/compare.php?from=773e5dfbc6bf4d4c5be568a039661e9baad80d15&to=7ba15f3a4b59181110e73dc397a9fe56165a2b73&stat=instructions:u

Diff Detail

Event Timeline

vitalybuka created this revision.Feb 18 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 1:25 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
vitalybuka requested review of this revision.Feb 18 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 1:25 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
vitalybuka added reviewers: nikic, Florian.Feb 18 2023, 1:26 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptFeb 18 2023, 1:26 PM
vitalybuka edited reviewers, added: fhahn; removed: Florian.Feb 18 2023, 1:26 PM
vitalybuka updated this revision to Diff 498624.Feb 18 2023, 1:28 PM

fix rebase conflicts

vitalybuka updated this revision to Diff 498626.Feb 18 2023, 1:35 PM

another rebase conflict

vitalybuka updated this revision to Diff 498627.Feb 18 2023, 1:42 PM

clang-format

vitalybuka edited the summary of this revision. (Show Details)Feb 18 2023, 1:58 PM
vitalybuka edited the summary of this revision. (Show Details)Feb 18 2023, 2:02 PM
Harbormaster completed remote builds in B214599: Diff 498627.Feb 18 2023, 2:26 PM
fhahn mentioned this in D144382: [SCEV] Increase FoldID bits size cover common cases..Feb 20 2023, 4:50 AM
fhahn mentioned this in rGeddecd3ade5c: [SCEV] Increase FoldID bits size cover common cases..Feb 24 2023, 12:43 AM
vitalybuka updated this revision to Diff 500315.Feb 24 2023, 3:14 PM

rebase

vitalybuka edited the summary of this revision. (Show Details)Feb 24 2023, 3:52 PM

This one still improves on top of D144382.

Harbormaster completed remote builds in B215843: Diff 500315.Feb 25 2023, 12:46 AM
vitalybuka updated this revision to Diff 502861.Mar 6 2023, 4:46 PM

simplify

Harbormaster completed remote builds in B217754: Diff 502861.Mar 6 2023, 9:56 PM
vitalybuka added a comment.Mar 8 2023, 1:08 PM
In D144335#4173558, @vitalybuka wrote:

simplify

@fhahn
is there a reason not to commit this?

nikic added a comment.Mar 8 2023, 1:11 PM

I believe the idea behind FoldID was to allow extending it to other SCEV types in the future. That said, I don't think we have specific plans for this right now, so it may makes sense to specialize to the types we're currently interested in.

vitalybuka updated this revision to Diff 525382.Wed, May 24, 5:36 PM

rebase

vitalybuka added a comment.Wed, May 24, 5:36 PM

ping

Harbormaster completed remote builds in B234359: Diff 525382.Wed, May 24, 7:10 PM
vitalybuka added a reviewer: MaskRay.Wed, May 31, 2:49 PM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Analysis/
52 lines
lib/
Analysis/
10 lines

Diff 525382

View Options

llvm/include/llvm/Analysis/ScalarEvolution.h

Loading...
View Options

llvm/lib/Analysis/ScalarEvolution.cpp

Loading...