[hwasan] Add definitions for missing operator delete functions

[mcgrathr]

lgtm

[mcgrathr]

This indicates a lack of testing coverage for the runtime. We should add runtime tests that use all the allocator signatures explicitly.

[leonardchan]

In D144030#4126713, @mcgrathr wrote:

This indicates a lack of testing coverage for the runtime. We should add runtime tests that use all the allocator signatures explicitly.

Added tests for the suite of operator new/delete functions. I'll give it a day to see if anyone else has comments before landing.

[vitalybuka]

@kstoimenov Can be this the cause of false leaks?

[thakis]

As far as I can tell this doesn't build: http://45.33.8.238/linux/99657/step_10.txt

[dyung]

It also failed with a similar error on our bot https://lab.llvm.org/buildbot/#/builders/247/builds/1627

compiler-rt/lib/hwasan/hwasan_new_delete.cpp

     void *ptr, std::nothrow_t const &) {
   OPERATOR_DELETE_BODY;
 }
+INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete(
+    void *ptr, size_t) NOEXCEPT {
+  OPERATOR_DELETE_BODY;
+}
+INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete[](
+    void *ptr, size_t) NOEXCEPT {
+  OPERATOR_DELETE_BODY;
+}
 
 #endif  // OPERATOR_NEW_BODY
 

     void *ptr, std::align_val_t, std::nothrow_t const &) NOEXCEPT {
   OPERATOR_DELETE_BODY;
 }
+INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete(
+    void *ptr, size_t, std::align_val_t, std::nothrow_t const &) NOEXCEPT {
+  OPERATOR_DELETE_BODY;
+}
+INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete[](
+    void *ptr, size_t, std::align_val_t, std::nothrow_t const &) NOEXCEPT {
+  OPERATOR_DELETE_BODY;
+}
 
 #endif  // OPERATOR_NEW_ALIGN_BODY