Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People kstoimenov

kstoimenov (Kirill Stoimenov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2021, 3:54 PM (115 w, 4 d)

Recent Activity
View All

Aug 23 2023

kstoimenov accepted D158525: [asan] Remove unnecessary spill in optimized callbacks.
Aug 23 2023, 3:02 PM · Restricted Project, Restricted Project

Aug 15 2023

kstoimenov accepted D157947: [sanitizer] Add CMake flag to build with internal symbolizer.
Aug 15 2023, 5:55 PM · Restricted Project, Restricted Project
kstoimenov accepted D157945: [sanitizer] Backup errno calling symbolizer.
Aug 15 2023, 1:20 PM · Restricted Project, Restricted Project
kstoimenov accepted D157946: [test][sanitizer] Prepare test for Internal Symbolizer.
Aug 15 2023, 1:15 PM · Restricted Project, Restricted Project

Aug 9 2023

kstoimenov accepted D157552: [asan] Fix GC of FakeFrames.
Aug 9 2023, 3:58 PM · Restricted Project, Restricted Project

Jul 26 2023

kstoimenov accepted D156299: [asan] Block signals when starting threads.
Jul 26 2023, 9:50 AM · Restricted Project, Restricted Project
kstoimenov accepted D156298: [NFC][asan] Replace start_routine_ and arg_ with opaque start_data_ field.
Jul 26 2023, 9:49 AM · Restricted Project, Restricted Project
kstoimenov accepted D156290: [NFC][asan] Split AsanThread::ThreadStart.
Jul 26 2023, 9:43 AM · Restricted Project, Restricted Project

Jul 24 2023

kstoimenov accepted D156183: [NFC] Remove redundant branch.
Jul 24 2023, 4:45 PM · Restricted Project, Restricted Project

Jul 21 2023

kstoimenov committed rG51e49e12e7cb: [HWASAN][LSAN] Replace cstdint with stdint.h (authored by kstoimenov).
[HWASAN][LSAN] Replace cstdint with stdint.h
Jul 21 2023, 3:20 PM · Restricted Project, Restricted Project
kstoimenov closed D155994: [HWASAN][LSAN] Replace cstdint with stdint.h.
Jul 21 2023, 3:20 PM · Restricted Project, Restricted Project
kstoimenov added a reviewer for D155994: [HWASAN][LSAN] Replace cstdint with stdint.h: brooksmoses.
Jul 21 2023, 2:19 PM · Restricted Project, Restricted Project
kstoimenov requested review of D155994: [HWASAN][LSAN] Replace cstdint with stdint.h.
Jul 21 2023, 2:18 PM · Restricted Project, Restricted Project

Jul 18 2023

kstoimenov updated the summary of D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 18 2023, 2:16 PM · Restricted Project, Restricted Project
kstoimenov committed rG0365ccd2a1b3: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64 (authored by kstoimenov).
[HWASAN][LSAN] Fix false positive memory leak reports on X86_64
Jul 18 2023, 12:05 PM · Restricted Project, Restricted Project
kstoimenov closed D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 18 2023, 12:04 PM · Restricted Project, Restricted Project
kstoimenov added inline comments to D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 18 2023, 11:30 AM · Restricted Project, Restricted Project
kstoimenov retitled D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64 from [HWASAN][LSAN] Fix false positive memory leak reports on X86 to [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 18 2023, 11:28 AM · Restricted Project, Restricted Project
kstoimenov retitled D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64 from [HWASAN][LSAN] Fix false positive memeory leak reports on X86 to [HWASAN][LSAN] Fix false positive memory leak reports on X86.
Jul 18 2023, 11:24 AM · Restricted Project, Restricted Project

Jul 17 2023

kstoimenov added inline comments to D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 17 2023, 5:23 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.

Addressed comments.

Jul 17 2023, 5:23 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.

Removed include.

Jul 17 2023, 3:23 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.

Updated comment.

Jul 17 2023, 3:23 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.

Added a test.

Jul 17 2023, 3:20 PM · Restricted Project, Restricted Project

Jul 14 2023

kstoimenov added a reviewer for D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64: vitalybuka.
Jul 14 2023, 2:26 PM · Restricted Project, Restricted Project
kstoimenov requested review of D155338: [HWASAN][LSAN] Fix false positive memory leak reports on X86_64.
Jul 14 2023, 1:54 PM · Restricted Project, Restricted Project

Jul 7 2023

kstoimenov committed rG3c0ae1f5ab13: [ASAN] Moved mmap/munmap test to posix. (authored by kstoimenov).
[ASAN] Moved mmap/munmap test to posix.
Jul 7 2023, 3:44 PM · Restricted Project, Restricted Project
kstoimenov committed rG9b79e15da189: [ASAN] Disable mmap test on Windows. (authored by kstoimenov).
[ASAN] Disable mmap test on Windows.
Jul 7 2023, 11:47 AM · Restricted Project, Restricted Project
kstoimenov committed rGa34e702aa16f: [ASAN] Add mmap and munmap interceptor in ASAN (authored by kstoimenov).
[ASAN] Add mmap and munmap interceptor in ASAN
Jul 7 2023, 8:49 AM · Restricted Project, Restricted Project
kstoimenov closed D154659: [ASAN] Add mmap and munmap interceptor in ASAN.
Jul 7 2023, 8:49 AM · Restricted Project, Restricted Project
kstoimenov updated the diff for D154659: [ASAN] Add mmap and munmap interceptor in ASAN.

Addressed comments.

Jul 7 2023, 8:37 AM · Restricted Project, Restricted Project

Jul 6 2023

kstoimenov added inline comments to D154659: [ASAN] Add mmap and munmap interceptor in ASAN.
Jul 6 2023, 3:43 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D154659: [ASAN] Add mmap and munmap interceptor in ASAN.

Addressed comments.

Jul 6 2023, 3:42 PM · Restricted Project, Restricted Project
kstoimenov added a reviewer for D154659: [ASAN] Add mmap and munmap interceptor in ASAN: vitalybuka.
Jul 6 2023, 3:01 PM · Restricted Project, Restricted Project
kstoimenov requested review of D154659: [ASAN] Add mmap and munmap interceptor in ASAN.
Jul 6 2023, 3:00 PM · Restricted Project, Restricted Project

Jun 27 2023

kstoimenov accepted D153664: [sanitizer] Relax the restriction on SizeClassAllocator64::kAllocatorSize.
Jun 27 2023, 3:53 PM · Restricted Project, Restricted Project

Jun 15 2023

kstoimenov committed rG7ebfc36f7e68: [Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL (authored by kstoimenov).
[Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL
Jun 15 2023, 4:19 PM · Restricted Project, Restricted Project
kstoimenov closed D152980: [Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL.
Jun 15 2023, 4:19 PM · Restricted Project, Restricted Project
kstoimenov added a comment to D152170: [ELF] Fix early overflow check in finalizeAddressDependentContent.

Build is green now. Thanks everyone!

Jun 15 2023, 3:55 PM · Restricted Project, Restricted Project
kstoimenov added a comment to D152170: [ELF] Fix early overflow check in finalizeAddressDependentContent.

Looks like this or D151802 broke the ubsan ARM bot: https://lab.llvm.org/buildbot/#/builders/238/builds/3938. Could you please revert or fix?

Jun 15 2023, 9:41 AM · Restricted Project, Restricted Project

Jun 14 2023

kstoimenov added inline comments to D152980: [Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL.
Jun 14 2023, 4:21 PM · Restricted Project, Restricted Project
kstoimenov added a reviewer for D152980: [Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL: vitalybuka.
Jun 14 2023, 4:21 PM · Restricted Project, Restricted Project
kstoimenov requested review of D152980: [Sanitizers] Remove unused parameter from COMMON_INTERCEPTOR_MUNMAP_IMPL.
Jun 14 2023, 4:19 PM · Restricted Project, Restricted Project
kstoimenov added inline comments to D152893: [hwasan] Fixup mmap tagging regions.
Jun 14 2023, 2:56 PM · Restricted Project, Restricted Project
kstoimenov added inline comments to D152893: [hwasan] Fixup mmap tagging regions.
Jun 14 2023, 11:06 AM · Restricted Project, Restricted Project
kstoimenov committed rGceab8e3af7d8: [HWASAN] Fix bot test failure caused by D152763 by switching to (authored by kstoimenov).
[HWASAN] Fix bot test failure caused by D152763 by switching to
Jun 14 2023, 7:57 AM · Restricted Project, Restricted Project
kstoimenov closed D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Will submit as separate patch.

Jun 14 2023, 7:54 AM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Switched to unaligned.

Jun 14 2023, 7:47 AM · Restricted Project, Restricted Project
kstoimenov reopened D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Breaks the build bot. Will fix forward.

Jun 14 2023, 7:25 AM · Restricted Project, Restricted Project

Jun 13 2023

kstoimenov committed rGfba9fd1afa70: [HWASAN] Implement munmap interceptor for HWASAN (authored by kstoimenov).
[HWASAN] Implement munmap interceptor for HWASAN
Jun 13 2023, 10:37 PM · Restricted Project, Restricted Project
kstoimenov closed D152763: [HWASAN] Implement munmap interceptor for HWASAN.
Jun 13 2023, 10:37 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Updated to TagMem.

Jun 13 2023, 10:30 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Address comments.

Jun 13 2023, 5:10 PM · Restricted Project, Restricted Project
kstoimenov added a comment to D151785: [clangd] Desugar template parameter aliases in type hints.
In D151785#4418037, @zyounan wrote:
In D151785#4417973, @kstoimenov wrote:

Looks like this might have broken a couple of sanitizer builds. Here is one of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you please revert or fix?
Thanks!

Sorry for the inconvenience. I think this issue had been fixed by https://github.com/llvm/llvm-project/commit/0e8384a0fe4f03d60cd92aba1cae074512481ca2. Does it work now? Please let me know if we still have problems.

Jun 13 2023, 4:00 PM · Restricted Project, Restricted Project
kstoimenov added inline comments to D152763: [HWASAN] Implement munmap interceptor for HWASAN.
Jun 13 2023, 3:57 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Updated the test.

Jun 13 2023, 3:55 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Fixed unmap.

Jun 13 2023, 12:10 PM · Restricted Project, Restricted Project
kstoimenov added a comment to D151785: [clangd] Desugar template parameter aliases in type hints.

Looks like this might have broken a couple of sanitizer builds. Here is one of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you please revert or fix?
Thanks!

Jun 13 2023, 9:32 AM · Restricted Project, Restricted Project
kstoimenov added inline comments to D152763: [HWASAN] Implement munmap interceptor for HWASAN.
Jun 13 2023, 9:16 AM · Restricted Project, Restricted Project

Jun 12 2023

kstoimenov added reviewers for D152763: [HWASAN] Implement munmap interceptor for HWASAN: vitalybuka, thurston.
Jun 12 2023, 5:28 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Updated order.

Jun 12 2023, 5:28 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152763: [HWASAN] Implement munmap interceptor for HWASAN.

Updated comment.

Jun 12 2023, 5:27 PM · Restricted Project, Restricted Project
kstoimenov requested review of D152763: [HWASAN] Implement munmap interceptor for HWASAN.
Jun 12 2023, 5:25 PM · Restricted Project, Restricted Project
kstoimenov committed rG686cb26edbe1: [Sanitizer] Add munmap interceptor in sanitizer_common (authored by kstoimenov).
[Sanitizer] Add munmap interceptor in sanitizer_common
Jun 12 2023, 2:34 PM · Restricted Project, Restricted Project
kstoimenov closed D152598: [Sanitizer] Add munmap interceptor in sanitizer_common.
Jun 12 2023, 2:34 PM · Restricted Project, Restricted Project
kstoimenov added a reviewer for D152598: [Sanitizer] Add munmap interceptor in sanitizer_common: thurston.
Jun 12 2023, 11:08 AM · Restricted Project, Restricted Project
kstoimenov updated the diff for D152598: [Sanitizer] Add munmap interceptor in sanitizer_common.

Fixed tests.

Jun 12 2023, 11:07 AM · Restricted Project, Restricted Project

Jun 9 2023

kstoimenov added a reviewer for D152598: [Sanitizer] Add munmap interceptor in sanitizer_common: vitalybuka.
Jun 9 2023, 5:12 PM · Restricted Project, Restricted Project
kstoimenov requested review of D152598: [Sanitizer] Add munmap interceptor in sanitizer_common.
Jun 9 2023, 5:10 PM · Restricted Project, Restricted Project

May 25 2023

kstoimenov accepted D151262: hwasan: enable mmap interception (no tagging used).
May 25 2023, 3:55 PM · Restricted Project, Restricted Project
kstoimenov added inline comments to D151262: hwasan: enable mmap interception (no tagging used).
May 25 2023, 2:37 PM · Restricted Project, Restricted Project

May 24 2023

kstoimenov accepted D151352: [msan] Implement __sanitizer_get_current_allocated_bytes.

Could you please provide a little bit more context around the bug that this is fixing?

May 24 2023, 10:44 AM · Restricted Project, Restricted Project

Apr 26 2023

kstoimenov accepted D149221: [NFC][HWASAN] Move getUARTag into the Entry.
Apr 26 2023, 2:18 PM · Restricted Project, Restricted Project
kstoimenov accepted D149293: [HWASAN] Fix HwasanReallocate in aliasing mode.
Apr 26 2023, 2:12 PM · Restricted Project, Restricted Project
kstoimenov added a comment to D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen.

Looks like this broke our sanitizer bot: https://lab.llvm.org/buildbot/#/builders/5/builds/33303. Could you please revert or fix forward?

Apr 26 2023, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
kstoimenov accepted D149220: [HWASAN] Remove UAR tag branch !ClUARRetagToZero.
Apr 26 2023, 11:28 AM · Restricted Project, Restricted Project
kstoimenov added a comment to D149219: [test][HWASAN] Regenerate some HWASAN tests.

May add some description regarding how this was regenerated?

Apr 26 2023, 11:27 AM · Restricted Project, Restricted Project
kstoimenov accepted D149219: [test][HWASAN] Regenerate some HWASAN tests.
Apr 26 2023, 11:26 AM · Restricted Project, Restricted Project
kstoimenov committed rG7d5e6b4bc7f8: [HWASAN] Fix TLS + signal handling related crash (authored by kstoimenov).
[HWASAN] Fix TLS + signal handling related crash
Apr 26 2023, 11:08 AM · Restricted Project, Restricted Project
kstoimenov closed D149085: [HWASAN] Fix TLS + signal handling related crash.
Apr 26 2023, 11:08 AM · Restricted Project, Restricted Project
kstoimenov accepted D149261: [MLIR][python bindings] Reimplement `replace_all_uses_with` on `PyValue`.
Apr 26 2023, 11:05 AM · Restricted Project, Restricted Project
kstoimenov abandoned D147067: [HWASAN] Turn on sanitizer common tests for HWASAN.
Apr 26 2023, 11:04 AM · Restricted Project, Restricted Project
kstoimenov accepted D149234: [HWASAN] Run sanitizer_common tests.
Apr 26 2023, 11:03 AM · Restricted Project, Restricted Project
kstoimenov accepted D149227: [HWASAN] Untag pointer with TagMaskByte instead 0xFF.
Apr 26 2023, 8:14 AM · Restricted Project, Restricted Project
kstoimenov retitled D149227: [HWASAN] Untag pointer with TagMaskByte instead 0xFF from [HWASAN] Untag pointe with TagMaskByte instead 0xFF to [HWASAN] Untag pointer with TagMaskByte instead 0xFF.
Apr 26 2023, 8:12 AM · Restricted Project, Restricted Project
kstoimenov accepted D149241: [hwasan] Implement __sanitizer_purge_allocator.
Apr 26 2023, 8:12 AM · Restricted Project, Restricted Project
kstoimenov accepted D149238: [HWASAN] Fix __sanitizer_get_allocated_{begin,size}.
Apr 26 2023, 8:08 AM · Restricted Project, Restricted Project

Apr 25 2023

kstoimenov added a comment to D148816: [MLIR][python bindings] implement `replace_all_uses_with` on `PyValue`.

Looks like this broke our ASAN bot: https://lab.llvm.org/buildbot/#/builders/168/builds/13141. Could you please revert or fix forward?

Apr 25 2023, 11:54 AM · Restricted Project, Restricted Project

Apr 24 2023

kstoimenov retitled D149085: [HWASAN] Fix TLS + signal handling related crash from [HWASAN] Fix signal handling related HWASAN crash to [HWASAN] Fix TLS + signal handling related crash.
Apr 24 2023, 4:41 PM · Restricted Project, Restricted Project
kstoimenov retitled D149085: [HWASAN] Fix TLS + signal handling related crash from [HWASAN] Fix a crash when a singal is raised before HWASAN TLS is initialized by disabling singals at thread start time. to [HWASAN] Fix signal handling related HWASAN crash.
Apr 24 2023, 4:40 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D149085: [HWASAN] Fix TLS + signal handling related crash.

Addressed comments.

Apr 24 2023, 4:39 PM · Restricted Project, Restricted Project
kstoimenov added a reviewer for D149085: [HWASAN] Fix TLS + signal handling related crash: vitalybuka.
Apr 24 2023, 12:28 PM · Restricted Project, Restricted Project
kstoimenov requested review of D149085: [HWASAN] Fix TLS + signal handling related crash.
Apr 24 2023, 12:27 PM · Restricted Project, Restricted Project

Apr 14 2023

kstoimenov accepted D148390: [NFC][lsan] Move SetCurrentThread call.
Apr 14 2023, 4:18 PM · Restricted Project, Restricted Project
kstoimenov accepted D148281: [lsan] Don't crash on ThreadRegistry::threads_ data race.
Apr 14 2023, 7:30 AM · Restricted Project, Restricted Project

Apr 4 2023

kstoimenov committed rGd917da66c894: [HWASAN] Fix test which was failing with tag mismatch due to missing… (authored by kstoimenov).
[HWASAN] Fix test which was failing with tag mismatch due to missing…
Apr 4 2023, 12:43 PM · Restricted Project, Restricted Project

Mar 28 2023

kstoimenov accepted D147076: Disable resize_tls_dynamic test for HWASan.
Mar 28 2023, 1:44 PM · Restricted Project, Restricted Project
kstoimenov updated the diff for D147067: [HWASAN] Turn on sanitizer common tests for HWASAN.

New line.

Mar 28 2023, 10:32 AM · Restricted Project, Restricted Project
kstoimenov retitled D147067: [HWASAN] Turn on sanitizer common tests for HWASAN from LSAN to [HWASAN] Turn on sanitizer common tests for HWASAN.
Mar 28 2023, 10:31 AM · Restricted Project, Restricted Project
kstoimenov updated the diff for D147067: [HWASAN] Turn on sanitizer common tests for HWASAN.

Rename.

Mar 28 2023, 10:30 AM · Restricted Project, Restricted Project