This is an archive of the discontinued LLVM Phabricator instance.

Remove Renderscript support from LLDB
ClosedPublic

Authored by kongyi on Feb 13 2023, 11:54 PM.

Diff Detail

Event Timeline

kongyi created this revision.Feb 13 2023, 11:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 11:54 PM
Herald added a subscriber: mattd. · View Herald Transcript
kongyi requested review of this revision.Feb 13 2023, 11:54 PM
srhines accepted this revision.Feb 14 2023, 12:32 PM

Thanks for cleaning this up, @kongyi.

This revision is now accepted and ready to land.Feb 14 2023, 12:32 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2023, 10:54 AM
kazu added a subscriber: kazu.Feb 16 2023, 3:06 PM

This patch seems to trigger:

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:398:34: error: variable 'lang_rt' set but not used [-Werror,-Wunused-but-set-variable]
  lldb_private::LanguageRuntime *lang_rt = nullptr;
                                 ^

Would you mind looking into this? Thanks!

kazu added a comment.Feb 16 2023, 5:58 PM

This patch seems to trigger:

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:398:34: error: variable 'lang_rt' set but not used [-Werror,-Wunused-but-set-variable]
  lldb_private::LanguageRuntime *lang_rt = nullptr;
                                 ^

Would you mind looking into this? Thanks!

The warning was fixed with:

https://github.com/llvm/llvm-project/commit/58bedaed0fea43fbf14bdb5f1da500528ca6dc80

lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.h