This is an archive of the discontinued LLVM Phabricator instance.

[mlir][llvm] Import alias scope metadata from LLVM IR.
ClosedPublic

Authored by gysit on Feb 13 2023, 8:47 AM.

Details

Summary

The revision adds support for importing alias.scope and noalias metadata
from LLVM IR into LLVM dialect. It also adds a verifier to the
AliasScopeMetadataOp to check that the associated domain exists
and is of type AliasScopeDomainMetadataOp.

Diff Detail

Event Timeline

gysit created this revision.Feb 13 2023, 8:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
gysit requested review of this revision.Feb 13 2023, 8:47 AM
gysit updated this revision to Diff 497245.Feb 14 2023, 2:08 AM

Improve error handling and add tets.

Dinistro added inline comments.Feb 14 2023, 3:59 AM
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
2744

NIT: isa_and_nonnull<>() could be used here.

gysit updated this revision to Diff 497278.Feb 14 2023, 5:02 AM

Address review comments.

Dinistro accepted this revision.Feb 15 2023, 8:44 AM

LGTM!

This revision is now accepted and ready to land.Feb 15 2023, 8:44 AM
This revision was automatically updated to reflect the committed changes.