Page MenuHomePhabricator

[clang-tidy] Clarify bugprone-branch-clone diagnostic message

Authored by donat.nagy on Feb 13 2023, 7:52 AM.



This simple commit inserts "body" into the message "repeated branch body in conditional chain". This is motivated by feedback from a confused user who (at first glance) thought that clang-tidy complained about a repeated branch condition.

Diff Detail

Event Timeline

donat.nagy created this revision.Feb 13 2023, 7:52 AM
donat.nagy requested review of this revision.Feb 13 2023, 7:52 AM
donat.nagy retitled this revision from [clang-tidy] Clarify branch-clone diagnostic message to [clang-tidy] Clarify bugprone-branch-clone diagnostic message.
carlosgalvezp accepted this revision.Feb 13 2023, 10:59 AM

LGTM, thanks for the fix! Personally I don't think such a small change is worth mentioning in the Release Notes, but maybe other reviewers think differently, let's give them a couple of days.

This revision is now accepted and ready to land.Feb 13 2023, 10:59 AM
Eugene.Zelenko accepted this revision.Feb 13 2023, 11:02 AM

@donat.nagy Are you available to push the commit yourself? Otherwise I can help you with that, please let me know your name and email (must match those on your Github account) for attribution.

Thanks for the feedback! I can push the commit and I'll do so after a few days (if no changes are suggested).