This is an archive of the discontinued LLVM Phabricator instance.

llvm-tblgen: Split out CodeGenIntrinsics.cpp from CodeGenTarget.cpp
ClosedPublic

Authored by chapuni on Feb 12 2023, 3:54 AM.

Details

Summary

Let IntrinsicEmitter free from CodeGenTarget.h

For now, I have introduced llvm::tmp::getValueType(Rec) as a copy from
CodeGenTarget.cpp. This will be deleted in the near future, when
IntrinsicEmitter will not depend on MVT.

Diff Detail

Event Timeline

chapuni created this revision.Feb 12 2023, 3:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2023, 3:54 AM
Herald added a subscriber: mgrang. · View Herald Transcript
chapuni requested review of this revision.Feb 12 2023, 3:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2023, 3:54 AM
myhsu added a reviewer: myhsu.Feb 12 2023, 1:07 PM

This is 1st step to get rid of MVT in intrinsics_gen.
I have done personally, that IntrinsicEmitter works with not MVT but LLVMType in Intrinsics.td.
I expect that MVTEmitter could be implemented in MVT-free tblgen.

May I commit this? This is a NFC change but the key change to me.

One concern is; I introduce the namespace llmv::tmp.
As you would know to see D145937, I am planning to drop it.

arsenm added a subscriber: arsenm.Mar 14 2023, 7:45 AM
arsenm added inline comments.
llvm/utils/TableGen/CodeGenIntrinsics.h
28

Don't know what "sweep" means here

29

Drop the tmp namespace?

chapuni added inline comments.Mar 14 2023, 8:03 AM
llvm/utils/TableGen/CodeGenIntrinsics.h
29

Let me know better wording. I will drop entire llvm::tmp::getValueType() and its namespace.

chapuni added inline comments.Mar 14 2023, 3:31 PM
llvm/utils/TableGen/CodeGenIntrinsics.h
29

FIXME: Remove this when no longer needed.

I'll update the comment and commit it. Thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2023, 4:10 PM
This revision was automatically updated to reflect the committed changes.