This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions
ClosedPublic

Authored by carlosgalvezp on Feb 12 2023, 3:00 AM.

Details

Summary

Most of the options stated there are duplicated already in
the implementation of each check as a default value for
each option.

The only place where this is not the case is the nullptr
check. Move the default option there instead. Only the
HICPP guidelines alias this modernize check, and there is
nothing in the documentation that suggests it should have
a different default value than the main modernize check.

Diff Detail

Event Timeline

carlosgalvezp created this revision.Feb 12 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: xazax.hun. · View Herald Transcript
carlosgalvezp requested review of this revision.Feb 12 2023, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2023, 3:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko accepted this revision.Feb 12 2023, 7:34 AM

But will be good idea to notify authors of checks if they are still active.

This revision is now accepted and ready to land.Feb 12 2023, 7:34 AM