Page MenuHomePhabricator

angelgarcia (Angel Garcia)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2015, 1:37 AM (209 w, 6 d)

Recent Activity

Feb 3 2016

angelgarcia added a comment to D13893: Roll-back r250822..

The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).

Feb 3 2016, 1:17 PM

Nov 6 2015

angelgarcia committed rL252315: Allow the alias to be of a different type..
Allow the alias to be of a different type.
Nov 6 2015, 7:49 AM
angelgarcia closed D14442: Allow the alias to be of a different type..
Nov 6 2015, 7:49 AM
angelgarcia updated the diff for D14442: Allow the alias to be of a different type..

The test revealed a (already existing) bug. If we called getName() on a CXXConversionDecl, we would get the following assertion:

Nov 6 2015, 7:43 AM
angelgarcia added a comment to D14442: Allow the alias to be of a different type..

No. There is a test for that just before the one I added.

Nov 6 2015, 7:25 AM
angelgarcia retitled D14442: Allow the alias to be of a different type. from to Allow the alias to be of a different type..
Nov 6 2015, 7:21 AM
angelgarcia committed rL252308: Use the old index identifier by default, instead of 'elem'..
Use the old index identifier by default, instead of 'elem'.
Nov 6 2015, 7:05 AM
angelgarcia closed D14438: Use the old index identifier by default, instead of 'elem'..
Nov 6 2015, 7:05 AM
angelgarcia retitled D14438: Use the old index identifier by default, instead of 'elem'. from to Use the old index identifier by default, instead of 'elem'..
Nov 6 2015, 6:53 AM
angelgarcia committed rL252303: Avoid naming conflicts with the old index in modernize-loop-convert..
Avoid naming conflicts with the old index in modernize-loop-convert.
Nov 6 2015, 6:06 AM
angelgarcia closed D14437: Avoid naming conflicts with the old index in modernize-loop-convert..
Nov 6 2015, 6:06 AM
angelgarcia retitled D14437: Avoid naming conflicts with the old index in modernize-loop-convert. from to Avoid naming conflicts with the old index in modernize-loop-convert..
Nov 6 2015, 5:45 AM
angelgarcia committed rL252278: Fix another case where loop-convert wasn't handling correctly data members..
Fix another case where loop-convert wasn't handling correctly data members.
Nov 6 2015, 2:01 AM
angelgarcia closed D14378: Fix another case where loop-convert wasn't handling correctly data members..
Nov 6 2015, 2:01 AM

Nov 5 2015

angelgarcia updated the diff for D14378: Fix another case where loop-convert wasn't handling correctly data members..

Update the method comment.

Nov 5 2015, 5:52 AM
angelgarcia retitled D14378: Fix another case where loop-convert wasn't handling correctly data members. from to Fix another case where loop-convert wasn't handling correctly data members..
Nov 5 2015, 3:11 AM

Nov 4 2015

angelgarcia committed rL252041: Improve modernize-make-unique matcher..
Improve modernize-make-unique matcher.
Nov 4 2015, 2:30 AM
angelgarcia closed D14291: Improve modernize-make-unique matcher..
Nov 4 2015, 2:30 AM

Nov 3 2015

angelgarcia retitled D14291: Improve modernize-make-unique matcher. from to Improve modernize-make-unique matcher..
Nov 3 2015, 9:50 AM
angelgarcia committed rL251943: Handle correctly containers that are data members in modernize-loop-convert..
Handle correctly containers that are data members in modernize-loop-convert.
Nov 3 2015, 8:41 AM
angelgarcia closed D14289: Handle correctly containers that are data members in modernize-loop-convert..
Nov 3 2015, 8:40 AM
angelgarcia updated the diff for D14289: Handle correctly containers that are data members in modernize-loop-convert..

Merge with the latest revision.

Nov 3 2015, 8:40 AM
angelgarcia committed rL251940: Improve more the const-detection in modernize-loop-convert..
Improve more the const-detection in modernize-loop-convert.
Nov 3 2015, 8:34 AM
angelgarcia closed D14282: Improve more the const-detection in modernize-loop-convert..
Nov 3 2015, 8:33 AM
angelgarcia closed D14282: Improve more the const-detection in modernize-loop-convert. by committing rL251940: Improve more the const-detection in modernize-loop-convert..
Nov 3 2015, 8:33 AM
angelgarcia retitled D14289: Handle correctly containers that are data members in modernize-loop-convert. from to Handle correctly containers that are data members in modernize-loop-convert..
Nov 3 2015, 8:20 AM
angelgarcia retitled D14282: Improve more the const-detection in modernize-loop-convert. from to Improve more the const-detection in modernize-loop-convert..
Nov 3 2015, 6:04 AM

Nov 2 2015

angelgarcia committed rL251808: Make the modernize-loop-convert's const-detection smarter..
Make the modernize-loop-convert's const-detection smarter.
Nov 2 2015, 9:05 AM
angelgarcia closed D14198: Make the modernize-loop-convert's const-detection smarter..
Nov 2 2015, 9:05 AM
angelgarcia updated the diff for D14198: Make the modernize-loop-convert's const-detection smarter..

OK, is it better now?

Nov 2 2015, 9:01 AM
angelgarcia committed rL251807: Fix another crash in the redundant-void-arg check..
Fix another crash in the redundant-void-arg check.
Nov 2 2015, 8:20 AM
angelgarcia closed D14238: Fix another crash in the redundant-void-arg check..
Nov 2 2015, 8:20 AM
angelgarcia retitled D14238: Fix another crash in the redundant-void-arg check. from to Fix another crash in the redundant-void-arg check..
Nov 2 2015, 8:14 AM
angelgarcia committed rL251803: Remove unreachable that was reached in modernize-use-nullptr..
Remove unreachable that was reached in modernize-use-nullptr.
Nov 2 2015, 7:30 AM
angelgarcia closed D14229: Remove unreachable that was reached in modernize-use-nullptr..
Nov 2 2015, 7:30 AM
angelgarcia updated the diff for D14229: Remove unreachable that was reached in modernize-use-nullptr..

Merge lines.

Nov 2 2015, 7:30 AM
angelgarcia retitled D14229: Remove unreachable that was reached in modernize-use-nullptr. from to Remove unreachable that was reached in modernize-use-nullptr..
Nov 2 2015, 5:07 AM
angelgarcia committed rL251792: Fix crash in redundant-void-arg check..
Fix crash in redundant-void-arg check.
Nov 2 2015, 3:41 AM
angelgarcia closed D14204: Fix crash in redundant-void-arg check..
Nov 2 2015, 3:41 AM
angelgarcia closed D14204: Fix crash in redundant-void-arg check. by committing rL251792: Fix crash in redundant-void-arg check..
Nov 2 2015, 3:41 AM
angelgarcia updated the diff for D14204: Fix crash in redundant-void-arg check..

Sorry, I forgot. That case works just fine.

Nov 2 2015, 3:29 AM
angelgarcia updated the diff for D14204: Fix crash in redundant-void-arg check..

Use Lexer::makeFileCharRange (and a few changes due to clang-format).

Nov 2 2015, 3:07 AM
angelgarcia committed rL251790: Try to fix buildbots failure..
Try to fix buildbots failure.
Nov 2 2015, 2:57 AM
angelgarcia closed D14225: Try to fix buildbots failure. by committing rL251790: Try to fix buildbots failure..
Nov 2 2015, 2:57 AM
angelgarcia retitled D14225: Try to fix buildbots failure. from to Try to fix buildbots failure..
Nov 2 2015, 2:56 AM
angelgarcia committed rL251788: modernize-use-default supports copy constructor and copy-assignment operator..
modernize-use-default supports copy constructor and copy-assignment operator.
Nov 2 2015, 2:36 AM
angelgarcia closed D14145: modernize-use-default supports copy constructor and copy-assignment operator..
Nov 2 2015, 2:36 AM
angelgarcia added a comment to D14198: Make the modernize-loop-convert's const-detection smarter..

Reading just this function, it is unclear what the 'container' is.

It should be clearer now.

Nov 2 2015, 2:34 AM
angelgarcia updated the diff for D14198: Make the modernize-loop-convert's const-detection smarter..

Improve comments and add more tests.

Nov 2 2015, 2:34 AM

Oct 30 2015

angelgarcia retitled D14204: Fix crash in redundant-void-arg check. from to Fix crash in redundant-void-arg check..
Oct 30 2015, 8:41 AM
angelgarcia retitled D14198: Make the modernize-loop-convert's const-detection smarter. from to Make the modernize-loop-convert's const-detection smarter..
Oct 30 2015, 6:27 AM
angelgarcia committed rL251694: Only copy small types in modernize-loop-convert..
Only copy small types in modernize-loop-convert.
Oct 30 2015, 2:40 AM
angelgarcia closed D14176: Only copy small types in modernize-loop-convert..
Oct 30 2015, 2:40 AM
angelgarcia closed D14176: Only copy small types in modernize-loop-convert. by committing rL251694: Only copy small types in modernize-loop-convert..
Oct 30 2015, 2:40 AM
angelgarcia committed rL251693: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
Add "equalsNode" for types and "isCopyAssignmentOperator" matchers.
Oct 30 2015, 2:38 AM
angelgarcia closed D14152: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
Oct 30 2015, 2:38 AM

Oct 29 2015

angelgarcia retitled D14176: Only copy small types in modernize-loop-convert. from to Only copy small types in modernize-loop-convert..
Oct 29 2015, 7:42 AM
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..

Remove debugging code.

Oct 29 2015, 6:24 AM
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..

Put more logic into the matchers.

Oct 29 2015, 6:17 AM
angelgarcia updated the diff for D14152: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..

Add tests.

Oct 29 2015, 6:15 AM

Oct 28 2015

angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..

You can initialize an indirect base if it's virtual.

Oct 28 2015, 9:47 AM
angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..

In which cases can this be false? (I assume if not all are copied?)

Oct 28 2015, 9:30 AM
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..

Refactor most of the code to use AST matchers.

Oct 28 2015, 9:11 AM
angelgarcia retitled D14152: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers. from to Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
Oct 28 2015, 9:10 AM
angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..

OK, thanks! I will try to refactor some of the parts into AST matchers
then. It will probably take some time, though.

Oct 28 2015, 4:51 AM
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..

Small tweak.

Oct 28 2015, 4:26 AM
angelgarcia retitled D14145: modernize-use-default supports copy constructor and copy-assignment operator. from to modernize-use-default supports copy constructor and copy-assignment operator..
Oct 28 2015, 4:19 AM

Oct 22 2015

angelgarcia committed rL251015: Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Don't use "auto" on loops over fundamental types in modernize-loop-convert.
Oct 22 2015, 6:25 AM
angelgarcia closed D13982: Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Oct 22 2015, 6:25 AM
angelgarcia committed rL251013: Correctly print the type in modernize-make-unique..
Correctly print the type in modernize-make-unique.
Oct 22 2015, 6:23 AM
angelgarcia closed D13983: Correctly print the type in modernize-make-unique..
Oct 22 2015, 6:22 AM
angelgarcia retitled D13983: Correctly print the type in modernize-make-unique. from to Correctly print the type in modernize-make-unique..
Oct 22 2015, 6:12 AM
angelgarcia updated the diff for D13982: Don't use "auto" on loops over fundamental types in modernize-loop-convert..

Add a guard to check that ElemType is not null.

Oct 22 2015, 5:40 AM
angelgarcia retitled D13982: Don't use "auto" on loops over fundamental types in modernize-loop-convert. from to Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Oct 22 2015, 5:32 AM
angelgarcia committed rL251005: Make string constants in the modernize module static..
Make string constants in the modernize module static.
Oct 22 2015, 2:50 AM
angelgarcia closed D13975: Make string constants in the modernize module static..
Oct 22 2015, 2:50 AM
angelgarcia retitled D13975: Make string constants in the modernize module static. from to Make string constants in the modernize module static..
Oct 22 2015, 2:40 AM

Oct 21 2015

angelgarcia committed rL250897: Add modernize-use-default check to clang-tidy..
Add modernize-use-default check to clang-tidy.
Oct 21 2015, 6:00 AM
angelgarcia closed D13871: Add modernize-use-default check to clang-tidy..
Oct 21 2015, 6:00 AM

Oct 20 2015

angelgarcia committed rL250827: Roll-back r250822..
Roll-back r250822.
Oct 20 2015, 6:27 AM
angelgarcia closed D13893: Roll-back r250822. by committing rL250827: Roll-back r250822..
Oct 20 2015, 6:26 AM
angelgarcia retitled D13893: Roll-back r250822. from to Roll-back r250822..
Oct 20 2015, 6:23 AM
angelgarcia committed rL250824: Apply modernize-use-default to clang-tools-extra..
Apply modernize-use-default to clang-tools-extra.
Oct 20 2015, 5:58 AM
angelgarcia closed D13889: Apply modernize-use-default to clang-tools-extra..
Oct 20 2015, 5:58 AM
angelgarcia committed rL250822: Apply modernize-use-default to clang..
Apply modernize-use-default to clang.
Oct 20 2015, 5:56 AM
angelgarcia committed rL250823: Apply modernize-use-default to compiler-rt..
Apply modernize-use-default to compiler-rt.
Oct 20 2015, 5:56 AM
angelgarcia closed D13892: Apply modernize-use-default to compiler-rt. by committing rL250823: Apply modernize-use-default to compiler-rt..
Oct 20 2015, 5:55 AM
angelgarcia closed D13892: Apply modernize-use-default to compiler-rt..
Oct 20 2015, 5:55 AM
angelgarcia closed D13890: Apply modernize-use-default to clang..
Oct 20 2015, 5:55 AM
angelgarcia updated the diff for D13892: Apply modernize-use-default to compiler-rt..

Put comments back.

Oct 20 2015, 5:51 AM
angelgarcia updated the diff for D13890: Apply modernize-use-default to clang..

Put comment back.

Oct 20 2015, 5:49 AM
angelgarcia retitled D13892: Apply modernize-use-default to compiler-rt. from to Apply modernize-use-default to compiler-rt..
Oct 20 2015, 5:38 AM
angelgarcia retitled D13891: Apply modernize-use-default to llvm. from to Apply modernize-use-default to llvm..
Oct 20 2015, 5:36 AM
angelgarcia retitled D13890: Apply modernize-use-default to clang. from to Apply modernize-use-default to clang..
Oct 20 2015, 5:33 AM
angelgarcia retitled D13889: Apply modernize-use-default to clang-tools-extra. from to Apply modernize-use-default to clang-tools-extra..
Oct 20 2015, 5:30 AM
angelgarcia updated the diff for D13871: Add modernize-use-default check to clang-tidy..

Remove the fixme.

Oct 20 2015, 5:26 AM
angelgarcia updated the diff for D13871: Add modernize-use-default check to clang-tidy..

Global variable -> static, and a few other additions.

Oct 20 2015, 1:33 AM

Oct 19 2015

angelgarcia retitled D13871: Add modernize-use-default check to clang-tidy. from to Add modernize-use-default check to clang-tidy..
Oct 19 2015, 8:10 AM

Oct 16 2015

angelgarcia committed rL250523: Replacements in different files do not overlap..
Replacements in different files do not overlap.
Oct 16 2015, 9:17 AM
angelgarcia closed D13810: Replacements in different files do not overlap. by committing rL250523: Replacements in different files do not overlap..
Oct 16 2015, 9:17 AM