User Details
User Details
- User Since
- Aug 11 2015, 1:37 AM (424 w, 6 d)
Feb 3 2016
Feb 3 2016
angelgarcia added a comment to D13893: Roll-back r250822..
The compiler complained about creating constant instances of classes
without a user provided constructor (which is the case for the ASTMatchers).
Nov 6 2015
Nov 6 2015
Allow the alias to be of a different type.
angelgarcia updated the diff for D14442: Allow the alias to be of a different type..
The test revealed a (already existing) bug. If we called getName() on a CXXConversionDecl, we would get the following assertion:
angelgarcia added a comment to D14442: Allow the alias to be of a different type..
No. There is a test for that just before the one I added.
angelgarcia retitled D14442: Allow the alias to be of a different type. from to Allow the alias to be of a different type..
Use the old index identifier by default, instead of 'elem'.
angelgarcia retitled D14438: Use the old index identifier by default, instead of 'elem'. from to Use the old index identifier by default, instead of 'elem'..
angelgarcia committed rL252303: Avoid naming conflicts with the old index in modernize-loop-convert..
Avoid naming conflicts with the old index in modernize-loop-convert.
angelgarcia retitled D14437: Avoid naming conflicts with the old index in modernize-loop-convert. from to Avoid naming conflicts with the old index in modernize-loop-convert..
angelgarcia committed rL252278: Fix another case where loop-convert wasn't handling correctly data members..
Fix another case where loop-convert wasn't handling correctly data members.
Nov 5 2015
Nov 5 2015
angelgarcia updated the diff for D14378: Fix another case where loop-convert wasn't handling correctly data members..
Update the method comment.
angelgarcia retitled D14378: Fix another case where loop-convert wasn't handling correctly data members. from to Fix another case where loop-convert wasn't handling correctly data members..
Nov 4 2015
Nov 4 2015
Improve modernize-make-unique matcher.
Nov 3 2015
Nov 3 2015
angelgarcia retitled D14291: Improve modernize-make-unique matcher. from to Improve modernize-make-unique matcher..
angelgarcia committed rL251943: Handle correctly containers that are data members in modernize-loop-convert..
Handle correctly containers that are data members in modernize-loop-convert.
angelgarcia updated the diff for D14289: Handle correctly containers that are data members in modernize-loop-convert..
Merge with the latest revision.
Improve more the const-detection in modernize-loop-convert.
angelgarcia retitled D14289: Handle correctly containers that are data members in modernize-loop-convert. from to Handle correctly containers that are data members in modernize-loop-convert..
angelgarcia retitled D14282: Improve more the const-detection in modernize-loop-convert. from to Improve more the const-detection in modernize-loop-convert..
Nov 2 2015
Nov 2 2015
Make the modernize-loop-convert's const-detection smarter.
angelgarcia updated the diff for D14198: Make the modernize-loop-convert's const-detection smarter..
OK, is it better now?
Fix another crash in the redundant-void-arg check.
angelgarcia retitled D14238: Fix another crash in the redundant-void-arg check. from to Fix another crash in the redundant-void-arg check..
Remove unreachable that was reached in modernize-use-nullptr.
angelgarcia updated the diff for D14229: Remove unreachable that was reached in modernize-use-nullptr..
Merge lines.
angelgarcia retitled D14229: Remove unreachable that was reached in modernize-use-nullptr. from to Remove unreachable that was reached in modernize-use-nullptr..
Fix crash in redundant-void-arg check.
angelgarcia updated the diff for D14204: Fix crash in redundant-void-arg check..
Sorry, I forgot. That case works just fine.
angelgarcia updated the diff for D14204: Fix crash in redundant-void-arg check..
Use Lexer::makeFileCharRange (and a few changes due to clang-format).
Try to fix buildbots failure.
angelgarcia closed D14225: Try to fix buildbots failure. by committing rL251790: Try to fix buildbots failure..
angelgarcia committed rL251788: modernize-use-default supports copy constructor and copy-assignment operator..
modernize-use-default supports copy constructor and copy-assignment operator.
angelgarcia added a comment to D14198: Make the modernize-loop-convert's const-detection smarter..
Reading just this function, it is unclear what the 'container' is.
It should be clearer now.
angelgarcia updated the diff for D14198: Make the modernize-loop-convert's const-detection smarter..
Improve comments and add more tests.
Oct 30 2015
Oct 30 2015
angelgarcia retitled D14204: Fix crash in redundant-void-arg check. from to Fix crash in redundant-void-arg check..
angelgarcia retitled D14198: Make the modernize-loop-convert's const-detection smarter. from to Make the modernize-loop-convert's const-detection smarter..
Only copy small types in modernize-loop-convert.
angelgarcia committed rL251693: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
Add "equalsNode" for types and "isCopyAssignmentOperator" matchers.
Oct 29 2015
Oct 29 2015
angelgarcia retitled D14176: Only copy small types in modernize-loop-convert. from to Only copy small types in modernize-loop-convert..
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..
Remove debugging code.
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..
Put more logic into the matchers.
angelgarcia updated the diff for D14152: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
Add tests.
Oct 28 2015
Oct 28 2015
angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..
You can initialize an indirect base if it's virtual.
angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..
In which cases can this be false? (I assume if not all are copied?)
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..
Refactor most of the code to use AST matchers.
angelgarcia retitled D14152: Add "equalsNode" for types and "isCopyAssignmentOperator" matchers. from to Add "equalsNode" for types and "isCopyAssignmentOperator" matchers..
angelgarcia added a comment to D14145: modernize-use-default supports copy constructor and copy-assignment operator..
OK, thanks! I will try to refactor some of the parts into AST matchers
then. It will probably take some time, though.
angelgarcia updated the diff for D14145: modernize-use-default supports copy constructor and copy-assignment operator..
Small tweak.
angelgarcia retitled D14145: modernize-use-default supports copy constructor and copy-assignment operator. from to modernize-use-default supports copy constructor and copy-assignment operator..
Oct 22 2015
Oct 22 2015
angelgarcia committed rL251015: Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Don't use "auto" on loops over fundamental types in modernize-loop-convert.
Correctly print the type in modernize-make-unique.
angelgarcia retitled D13983: Correctly print the type in modernize-make-unique. from to Correctly print the type in modernize-make-unique..
angelgarcia updated the diff for D13982: Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Add a guard to check that ElemType is not null.
angelgarcia retitled D13982: Don't use "auto" on loops over fundamental types in modernize-loop-convert. from to Don't use "auto" on loops over fundamental types in modernize-loop-convert..
Make string constants in the modernize module static.
angelgarcia retitled D13975: Make string constants in the modernize module static. from to Make string constants in the modernize module static..
Oct 21 2015
Oct 21 2015
Add modernize-use-default check to clang-tidy.
Oct 20 2015
Oct 20 2015
Apply modernize-use-default to clang-tools-extra.
Apply modernize-use-default to clang.
Apply modernize-use-default to compiler-rt.
angelgarcia updated the diff for D13892: Apply modernize-use-default to compiler-rt..
Put comments back.
angelgarcia updated the diff for D13890: Apply modernize-use-default to clang..
Put comment back.
angelgarcia retitled D13892: Apply modernize-use-default to compiler-rt. from to Apply modernize-use-default to compiler-rt..
angelgarcia retitled D13891: Apply modernize-use-default to llvm. from to Apply modernize-use-default to llvm..
angelgarcia retitled D13890: Apply modernize-use-default to clang. from to Apply modernize-use-default to clang..
angelgarcia retitled D13889: Apply modernize-use-default to clang-tools-extra. from to Apply modernize-use-default to clang-tools-extra..
angelgarcia updated the diff for D13871: Add modernize-use-default check to clang-tidy..
Remove the fixme.
angelgarcia updated the diff for D13871: Add modernize-use-default check to clang-tidy..
Global variable -> static, and a few other additions.
Oct 19 2015
Oct 19 2015
angelgarcia retitled D13871: Add modernize-use-default check to clang-tidy. from to Add modernize-use-default check to clang-tidy..
Oct 16 2015
Oct 16 2015
Replacements in different files do not overlap.