This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Link MLIRLoopLikeOpInterface to MLIRFuncDialect
AbandonedPublic

Authored by tblah on Feb 9 2023, 8:20 AM.

Details

Summary

Fixes broken shared libraries build by https://reviews.llvm.org/D141401

Diff Detail

Event Timeline

tblah created this revision.Feb 9 2023, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 8:20 AM
tblah requested review of this revision.Feb 9 2023, 8:20 AM
mehdi_amini added inline comments.Feb 9 2023, 8:50 AM
mlir/lib/Interfaces/CMakeLists.txt
52

That does not seems right to me and indicated a layering issue.

The original patch should probably be reverted in the meantime.

mehdi_amini added inline comments.Feb 9 2023, 7:00 PM
mlir/lib/Interfaces/CMakeLists.txt
52

I commented on the original revision that the issue seems to come from mlir/test/lib/Interfaces/LoopLikeInterface/CMakeLists.txt and not the interface as far as I can tell.

tblah abandoned this revision.Feb 10 2023, 2:32 AM