Add test coverage for https://github.com/llvm/llvm-project/issues/60563.
D142636 introduced a bug: incorrect disassembly of floating point inline
constants for v_pk_mov_b32, v_pk_add_f32, v_pk_mul_f32 and v_pk_fma_f32.
Precommit for D143574.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/MC/Disassembler/AMDGPU/gfx90a_features.txt | ||
---|---|---|
54 | It is unusual to add invalid tests with the purpose of fixing them in a separate patch. |
It is unusual to add invalid tests with the purpose of fixing them in a separate patch.
At a minimum, I think you should mention this in the description and make these patches dependent (stacked). Or they could be merged.
Aside from that, both patches look good, thanks.