clang-cl doesn't support -dumpmachine directly, so we need to
preface it with /clang: in order to get this probing function
to work.
This is needed in order to run cmake directly on the runtimes
directory.
Differential D143557
[CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig thieta on Feb 8 2023, 12:30 AM. Authored by
Details clang-cl doesn't support -dumpmachine directly, so we need to This is needed in order to run cmake directly on the runtimes
Diff Detail
Event TimelineComment Actions This seems reasonable and fine to me.
Comment Actions I'm not familiar with this cmake code, but it seems reasonable to lgtm if it works :) Comment Actions Whoops forgot your comment suggestion. Fixed that after I had landed this and pushed it as a NFC. Thanks! |
NIT: Single line comment suggestion: