Details
Details
- Reviewers
Mel-Chen ABataev Meinersbur
Diff Detail
Diff Detail
- Repository
- rT test-suite
- Build Status
Buildable 212047 Build 323766: arc lint + arc unit
Event Timeline
Comment Actions
LGTM, but some description of what is tested would be useful. I would not expect people to search for the initial commit, find D132063 in the comment, and hope that Phabricator is still up.
SingleSource/UnitTests/Vectorizer/index-select.cpp | ||
---|---|---|
31 | Could you add a comment on what the point of running on sorted data over random data is? Isn't it pointwise anyway? | |
99 | Some description of what is being tested would be useful. min_index_select_u32_u32_start_0 isn't very descriptive. |