Details
Diff Detail
- Repository
- rT test-suite
Event Timeline
LGTM, but some description of what is tested would be useful. I would not expect people to search for the initial commit, find D132063 in the comment, and hope that Phabricator is still up.
SingleSource/UnitTests/Vectorizer/index-select.cpp | ||
---|---|---|
32 | Could you add a comment on what the point of running on sorted data over random data is? Isn't it pointwise anyway? | |
100 | Some description of what is being tested would be useful. min_index_select_u32_u32_start_0 isn't very descriptive. |
Thanks, I added a test for that and a few other variants (different induction starts and Min values).
Thanks, I added a description to the commit message.
SingleSource/UnitTests/Vectorizer/index-select.cpp | ||
---|---|---|
32 | I added some comments here to describe what's being tested. I also changed it to use std::numeric_limits<Ty>::max() instead of -1 with unsigned types. | |
100 | Thanks, I added a description in the committed version. |
Could you add a comment on what the point of running on sorted data over random data is? Isn't it pointwise anyway?