This is an archive of the discontinued LLVM Phabricator instance.

[asan] Remove system_malloc_zone
ClosedPublic

Authored by kubamracek on Nov 4 2015, 8:17 AM.

Details

Summary

This seems to be dead code – system_malloc_zone is initialized as null and we never assign to it. This code is apparently currently never executed (in ASan), but is causes trouble for the TSan OS X port. Let's replace the checks with COMMON_MALLOC_ENTER (ENSURE_ASAN_INITED()).

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 39207.Nov 4 2015, 8:17 AM
kubamracek retitled this revision from to [asan] Remove system_malloc_zone.
kubamracek updated this object.
kubamracek added reviewers: samsonov, glider, kcc, dvyukov.
dvyukov edited edge metadata.Nov 4 2015, 8:28 AM

glider, can you please take a look at this?
I don't understand what happens here.

glider edited edge metadata.Nov 12 2015, 3:12 AM

looking, sorry for the delay

glider accepted this revision.Nov 12 2015, 3:14 AM
glider edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 12 2015, 3:14 AM
This revision was automatically updated to reflect the committed changes.