This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][Runtimes] Hide unused CMake variable messages for runtimes builds
ClosedPublic

Authored by jhuber6 on Feb 2 2023, 9:37 AM.

Details

Summary

The LLVM runtime build is used to bootstrap projects with the built LLVM
toolchain. This effectively re-runs CMake with the current build
directory. One problem is that this passes every common CMake variable
to the projects individually, some of which are not necessarily used.

This patch suppresses the unused variable warnings for the runtimes.
The standard CMake invocation should still be able to print out the
unused variables so it should not impact code quality.

Diff Detail

Event Timeline

jhuber6 created this revision.Feb 2 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 9:37 AM
jhuber6 requested review of this revision.Feb 2 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 9:37 AM

I don't feel super qualified to review this, but I also don't see any problems with it. So LGTM but this should probably wait for another set of eyes before landing (hence why I'm not using the accept button).

thieta accepted this revision.Feb 2 2023, 10:31 AM

I think this is fine. This warning is not very useful when used in this way.

This revision is now accepted and ready to land.Feb 2 2023, 10:31 AM