Page MenuHomePhabricator
Differential D143183

[mlir][bufferization] Reads from tensors with undefined data are not a conflict
ClosedPublic
Actions

Authored by springerm on Feb 2 2023, 6:57 AM.

Details

Reviewers
nicolasvasilache
chelini
Commits
rG1fdf06d6d79e: [mlir][bufferization] Reads from tensors with undefined data are not a conflict
Summary

Reading from tensor.empty or bufferization.alloc_tensor (without copy) cannot cause a conflict because these ops do not specify the contents of their result tensors.

Depends On: D143181

Diff Detail

Event Timeline

springerm created this revision.Feb 2 2023, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 6:57 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
springerm requested review of this revision.Feb 2 2023, 6:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 6:57 AM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
springerm added a parent revision: D143181: [mlir][tensor][bufferize] tensor.empty does not define the result tensor contents.Feb 2 2023, 6:58 AM
Herald added a subscriber: jsetoain. · View Herald TranscriptFeb 2 2023, 6:58 AM
springerm mentioned this in D143087: [mlir][bufferization] Fix bufferization of repetitive regions.Feb 2 2023, 7:25 AM
springerm added a child revision: D143087: [mlir][bufferization] Fix bufferization of repetitive regions.
Harbormaster completed remote builds in B211486: Diff 494295.Feb 2 2023, 7:51 AM
chelini added inline comments.Feb 6 2023, 12:36 AM
mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-analysis.mlir
36

Can we please add a test case also for bufferization.alloc_tensor?

springerm updated this revision to Diff 495026.Feb 6 2023, 1:20 AM
springerm marked an inline comment as done.

address comments

Harbormaster completed remote builds in B212020: Diff 495026.Feb 6 2023, 2:00 AM
chelini accepted this revision.Feb 6 2023, 7:01 AM
This revision is now accepted and ready to land.Feb 6 2023, 7:01 AM
Closed by commit rG1fdf06d6d79e: [mlir][bufferization] Reads from tensors with undefined data are not a conflict (authored by springerm). · Explain WhyFeb 6 2023, 7:16 AM
This revision was automatically updated to reflect the committed changes.
springerm added a commit: rG1fdf06d6d79e: [mlir][bufferization] Reads from tensors with undefined data are not a conflict.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Bufferization/
IR/
14 lines
lib/
Dialect/
Bufferization/
IR/
5 lines
Transforms/
27 lines
test/
Dialect/
Bufferization/
Transforms/
24 lines
SCF/
12 lines

Diff 495120

View Options

mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h

Loading...
View Options

mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp

Loading...
View Options

mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp

Loading...
View Options

mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-analysis.mlir

Loading...
View Options

mlir/test/Dialect/SCF/one-shot-bufferize.mlir

Loading...