Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
60,030 ms | x64 debian > LLVM-Unit.Analysis/_/AnalysisTests/30::41 |
Event Timeline
Comment Actions
Looks good to me in high level, but I suggest waiting for one more accept since I haven't been working with the LLVM codebase for a while.
Comment Actions
I don't think this is the correct check to do, and I also don't particularly want to introduce AA queries for this. The correct check is whether getUnderlyingObject(A) == getUnderlyingObject(B), in reasonable approximation. (There are more cases that are safe, e.g. a null pointer can be replaced with anything, but they are probably not very useful.)
I believe that if we actually want to fix this class of problems (which goes beyond GVN), we should fix it properly, and that starts with using the right predicate so we get a correct idea of the performance regressions we should expect.