This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Respect preamble-patch when handling diags

Authored by kadircet on Feb 1 2023, 10:35 AM.

Diff Detail

Event Timeline

kadircet created this revision.Feb 1 2023, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 10:35 AM
Herald added a subscriber: arphaman. · View Herald Transcript
kadircet requested review of this revision.Feb 1 2023, 10:35 AM
nridge added a subscriber: nridge.Feb 4 2023, 7:16 PM
sammccall accepted this revision.Feb 8 2023, 1:07 AM
sammccall added inline comments.

I think we answered this in the negative?


PLoc is a confusing name for something that interacts with but is not a PresumedLoc

I'd prefer avoiding auto here, too


just make it a function? it captures nothing

This revision is now accepted and ready to land.Feb 8 2023, 1:07 AM
kadircet updated this revision to Diff 495893.Feb 8 2023, 10:58 AM
kadircet marked 3 inline comments as done.
  • Drop FIXME for respecting all presumed locations
  • Use PatchLoc instead of PLoc
  • Rebase
This revision was automatically updated to reflect the committed changes.