Page MenuHomePhabricator
Differential D143075

BareMetal ToolChain multilib layering
AcceptedPublic
Actions

Authored by michaelplatings on Feb 1 2023, 7:52 AM.

Details

Reviewers
phosek
abidh
peter.smith
Summary

This enables layering baremetal multilibs on top of each other.
For example a multilib containing only a no-exceptions libc++ could be
layered on top of a multilib containing C libs. This avoids the need
to duplicate the C library for every libc++ variant.

Diff Detail

Event Timeline

michaelplatings created this revision.Feb 1 2023, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 7:52 AM
Herald added a subscriber: abidh. · View Herald Transcript
michaelplatings requested review of this revision.Feb 1 2023, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 7:52 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
michaelplatings added a parent revision: D143059: [Driver] Enable selecting multiple multilibs.Feb 1 2023, 7:52 AM
michaelplatings added a reviewer: abidh.
Herald added a subscriber: ki.stfu. · View Herald TranscriptFeb 1 2023, 7:53 AM
Harbormaster completed remote builds in B211229: Diff 493947.Feb 1 2023, 8:33 AM
amilendra added a subscriber: amilendra.Feb 2 2023, 9:28 PM
michaelplatings updated this revision to Diff 495559.Feb 7 2023, 8:35 AM

Rebase

Harbormaster completed remote builds in B212411: Diff 495559.Feb 7 2023, 12:02 PM
michaelplatings added a child revision: D143587: [Docs] Multilib design.Feb 8 2023, 7:30 AM
peter.smith added a subscriber: peter.smith.Feb 10 2023, 8:06 AM

No comments on the implementation.

michaelplatings updated this revision to Diff 499491.Feb 22 2023, 7:00 AM

Rebase and remove some braces

Harbormaster completed remote builds in B215244: Diff 499491.Feb 22 2023, 7:01 AM
michaelplatings updated this revision to Diff 499503.Feb 22 2023, 7:22 AM

Rebase

Harbormaster completed remote builds in B215255: Diff 499503.Feb 22 2023, 8:21 AM
michaelplatings updated this revision to Diff 499962.Feb 23 2023, 12:56 PM

PrintArgs -> PrintOptions

Harbormaster completed remote builds in B215593: Diff 499962.Feb 23 2023, 2:39 PM
michaelplatings updated this revision to Diff 503905.Mar 9 2023, 1:07 PM

flags -> tags

Harbormaster completed remote builds in B218497: Diff 503905.Mar 9 2023, 3:20 PM
peter.smith accepted this revision.Mar 13 2023, 9:26 AM

I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions.

This revision is now accepted and ready to land.Mar 13 2023, 9:26 AM
michaelplatings updated this revision to Diff 505052.Mar 14 2023, 5:42 AM

tags->flags

Harbormaster completed remote builds in B219324: Diff 505052.Mar 14 2023, 7:08 AM
michaelplatings updated this revision to Diff 505290.Mar 14 2023, 3:11 PM

Rebase

Harbormaster completed remote builds in B219497: Diff 505290.Mar 14 2023, 4:41 PM
michaelplatings updated this revision to Diff 508040.Mar 24 2023, 3:58 AM

Rebase

michaelplatings updated this revision to Diff 519003.May 3 2023, 1:08 AM

Rebase

phosek added inline comments.Tue, May 23, 1:34 AM
clang/lib/Driver/ToolChains/BareMetal.cpp
228

Can you use llvm::reverse instead of allocating an entire new collection?

Revision Contents
Changeset List

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines
106 lines
test/
Driver/
25 lines

Diff 519003

View Options

clang/lib/Driver/ToolChains/BareMetal.h

Loading...
View Options

clang/lib/Driver/ToolChains/BareMetal.cpp

Loading...
View Options

clang/test/Driver/baremetal-multilib.yaml

Loading...