This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass
ClosedPublic

Authored by antiagainst on Jan 31 2023, 6:14 PM.

Details

Summary

For the cases where we have aliases of vector<4xf16> and
vector<4xf32>, we need to do casting before composite
construction.

Diff Detail

Event Timeline

antiagainst created this revision.Jan 31 2023, 6:14 PM
antiagainst requested review of this revision.Jan 31 2023, 6:14 PM
kuhar accepted this revision.Feb 1 2023, 10:07 AM
kuhar added inline comments.
mlir/lib/Dialect/SPIRV/Transforms/UnifyAliasedResourcePass.cpp
498

nit: int64_t to match the return value?

This revision is now accepted and ready to land.Feb 1 2023, 10:07 AM
antiagainst marked an inline comment as done.Feb 1 2023, 11:36 AM