This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] Add folder for bitcast of integer splat constants
ClosedPublic

Authored by qedawkins on Jan 30 2023, 11:30 AM.

Details

Summary

This is a similar to the existing folder for f16 to f32 added with D96041 but instead for integer types where destination bits > source bits.

Diff Detail

Event Timeline

qedawkins created this revision.Jan 30 2023, 11:30 AM
qedawkins requested review of this revision.Jan 30 2023, 11:30 AM
antiagainst accepted this revision.Jan 30 2023, 4:34 PM
This revision is now accepted and ready to land.Jan 30 2023, 4:34 PM
ThomasRaoux added inline comments.Jan 30 2023, 4:42 PM
mlir/lib/Dialect/Vector/IR/VectorOps.cpp
4958

optional comment but it should be easy to generalize to any integer size using APInt.

qedawkins updated this revision to Diff 493465.Jan 30 2023, 5:55 PM

Generalize pattern to arbitrary bit widths

qedawkins updated this revision to Diff 493466.Jan 30 2023, 5:56 PM

add back initial commit

qedawkins added inline comments.Jan 30 2023, 6:04 PM
mlir/lib/Dialect/Vector/IR/VectorOps.cpp
4958

Amended to generalize to integer sizes where destination bit width > source bit width.

ThomasRaoux accepted this revision.Jan 30 2023, 6:57 PM

Nice :) Thanks! Make sure to update the title and description.

qedawkins retitled this revision from [mlir][vector] Add folder for bitcast of i8 splat constant to i32 to [mlir][vector] Add folder for bitcast of integer splat constants.Jan 30 2023, 7:28 PM
qedawkins edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jan 30 2023, 8:53 PM
This revision was automatically updated to reflect the committed changes.