[clang-format] Recognize Verilog non-blocking assignment
ClosedPublic
Actions

Authored by sstwcw on Jan 30 2023, 6:21 AM.

Details

Reviewers

Commits

	Time	Test
	3,690 ms	libcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp Script: -- : 'COMPILED WITH'; /home/libcxx-builder/.buildkite-agent/builds/1c7ac1ad85af-1/llvm-project/libcxx-ci/install/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/1c7ac1ad85af-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/1c7ac1ad85af-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/1c7ac1ad85af-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/1c7ac1ad85af-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only

sstwcw requested review of this revision.Jan 30 2023, 6:21 AM

sstwcw added a project: Restricted Project.Jan 30 2023, 6:27 AM

clang/lib/Format/WhitespaceManager.cpp
839–846	Do you need the extra case, or could you just activate `AlignCompound`? If you do, can you please add parens, the precedence of `?` and `:` in combination with `\|\|` is at least for me not 100% clear.

sstwcw marked an inline comment as done.Feb 2 2023, 7:23 AM

sstwcw added inline comments.

clang/lib/Format/WhitespaceManager.cpp
839–846	If I get you right, you are suggesting that `AlignCompound: false` is there only for backward compatibility, and we can make it default to true since we don't have to maintain backward compatibility for new things. I prefer consistency.